Replace file_put_contents (#76)

Author: withinboredom

src/index.php

@@ -22,6 +22,7 @@
 use Dapr\PubSub\Subscription;
 use Dapr\PubSub\Topic;
 use Dapr\State\Attributes\StateStore;
+use Dapr\State\FileWriter;
 use Dapr\State\StateManager;
 use Dapr\State\TransactionalState;
 use DI\ContainerBuilder;
@@ -422,7 +423,7 @@ function (
     ) {
         $logger->critical('Received an event: {subject}', ['subject' => $event->subject]);
         touch('/tmp/sub-received');
-        file_put_contents('/tmp/sub-received', $event->to_json());
+        FileWriter::write('/tmp/sub-received', $event->to_json());
 
         return [
             'status' => 'SUCCESS',

src/lib/Actors/Generators/CachedGenerator.php

@@ -2,6 +2,7 @@
 
 namespace Dapr\Actors\Generators;
 
+use Dapr\State\FileWriter;
 use DI\FactoryInterface;
 use JetBrains\PhpStorm\Pure;
 use Psr\Container\ContainerInterface;
@@ -48,7 +49,7 @@ public function get_proxy(string $id): object
                 mkdir($this->cache_dir);
             }
             $filename = $this->cache_dir.$this->get_short_class_name();
-            file_put_contents($filename, $file);
+            FileWriter::write($filename, $file);
             require_once $filename;
         }
 

src/lib/Actors/Internal/Caches/FileCache.php

@@ -2,6 +2,9 @@
 
 namespace Dapr\Actors\Internal\Caches;
 
+use Dapr\State\FileWriter;
+use phpDocumentor\Reflection\File;
+
 /**
  * Class FileCache
  * @package Dapr\Actors\Internal\Caches
@@ -78,6 +81,6 @@ private function serialize_cache()
             return;
         }
 
-        file_put_contents($this->cache_file, serialize($this->data));
+        FileWriter::write($this->cache_file, serialize($this->data));
     }
 }

src/lib/State/FileWriter.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace Dapr\State;
+
+/**
+ * Class FileWriter
+ * @package Dapr\State
+ */
+class FileWriter
+{
+    /**
+     * @param string $filename The filename to write to
+     * @param string $contents The contents of the file to write
+     */
+    public static function write(string $filename, string $contents)
+    {
+        $handle = fopen($filename, 'w');
+        if ($handle === false) {
+            throw new \RuntimeException('Unable to open '.$filename.' for writing!');
+        }
+        $content_length = strlen($contents);
+        $write_result   = fwrite($handle, $contents, $content_length);
+        if ($write_result !== $content_length) {
+            throw new \RuntimeException('Failed to write all content to '.$filename);
+        }
+        $flush_result = fflush($handle);
+        if ($flush_result === false) {
+            throw new \RuntimeException('Failed to flush '.$filename.' to disk.');
+        }
+        $close_result = fclose($handle);
+        unset($handle);
+        if ($close_result === false) {
+            throw new \RuntimeException('Failed to close '.$filename);
+        }
+    }
+}

tests/ActorTest.php

@@ -13,6 +13,7 @@
 use Dapr\exceptions\DaprException;
 use Dapr\exceptions\Http\NotFound;
 use Dapr\exceptions\SaveStateFailure;
+use Dapr\State\FileWriter;
 use DI\DependencyException;
 use DI\NotFoundException;
 use Fixtures\ActorClass;
@@ -357,7 +358,7 @@ public function testGeneratedClassIsCorrect()
         $generated_class = (string)FileGenerator::generate(ITestActor::class, $this->container);
         $take_snapshot   = false;
         if ($take_snapshot) {
-            file_put_contents(__DIR__.'/Fixtures/GeneratedProxy.php', $generated_class);
+            FileWriter::write(__DIR__.'/Fixtures/GeneratedProxy.php', $generated_class);
         }
         $expected_proxy = file_get_contents(__DIR__.'/Fixtures/GeneratedProxy.php');
         $this->assertSame($expected_proxy, $generated_class);