Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Commit 07d139f

Browse files
authored
fix: ignore doc comments for prefer-commenting-analyzer-ignores (#1115)
1 parent 2dd4c83 commit 07d139f

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* feat: add `strict` config option to [`avoid-collection-methods-with-unrelated-types`](https://dartcodemetrics.dev/docs/rules/common/avoid-collection-methods-with-unrelated-types).
66
* fix: support function expression invocations for [`prefer-moving-to-variable`](https://dartcodemetrics.dev/docs/rules/common/prefer-moving-to-variable).
77
* feat: support ignoring regular comments for [`format-comment`](https://dartcodemetrics.dev/docs/rules/common/format-comment).
8+
* fix: ignore doc comments for [`prefer-commenting-analyzer-ignores`](https://dartcodemetrics.dev/docs/rules/common/prefer-commenting-analyzer-ignores).
89

910
## 5.2.1
1011

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_commenting_analyzer_ignores/visitor.dart

+2-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ class _Visitor extends RecursiveAstVisitor<void> {
5454
final previous = node.previous;
5555

5656
return previous == null ||
57-
(previous.type != TokenType.SINGLE_LINE_COMMENT ||
57+
((previous.type != TokenType.SINGLE_LINE_COMMENT ||
58+
previous.toString().startsWith('///')) ||
5859
_lineInfo.getLocation(node.offset).lineNumber - 1 !=
5960
_lineInfo.getLocation(previous.offset).lineNumber);
6061
}

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_commenting_analyzer_ignores/examples/example.dart

+4
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,8 @@ void main() {
1818

1919
// ignore: avoid-non-null-assertion, checked for non-null
2020
final hashMap = HashMap();
21+
22+
/// documentation comment
23+
// ignore: avoid-non-null-assertion
24+
final value = 1; // LINT
2125
}

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_commenting_analyzer_ignores/prefer_commenting_analyzer_ignores_rule_test.dart

+4-2
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,17 @@ void main() {
2525

2626
RuleTestHelper.verifyIssues(
2727
issues: issues,
28-
startLines: [3, 6],
29-
startColumns: [3, 3],
28+
startLines: [3, 6, 23],
29+
startColumns: [3, 3, 3],
3030
locationTexts: [
3131
'// ignore: deprecated_member_use',
3232
'// ignore: deprecated_member_use, long-method',
33+
'// ignore: avoid-non-null-assertion',
3334
],
3435
messages: [
3536
'Prefer commenting analyzer ignores.',
3637
'Prefer commenting analyzer ignores.',
38+
'Prefer commenting analyzer ignores.',
3739
],
3840
);
3941
});

0 commit comments

Comments
 (0)