Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize hot reload rejections in a way that can be parsed mechanically in Flutter tools #60275

Open
srujzs opened this issue Mar 7, 2025 · 0 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler

Comments

@srujzs
Copy link
Contributor

srujzs commented Mar 7, 2025

Currently, we report hot reload rejections on the web in stderr during the frontend server compile:

throw new Exception(errors.join('/n') +
. This makes it difficult to:

  1. Discern between hot reload rejections and compile-time errors. The best we can do and do is parse the string for some token e.g. Hot reload rejected.
  2. Tell what hot reload rejection occurred e.g. making const classes non-const. This would be useful to report better metrics on the rejection in analytics. Today, we avoid reporting the error in analytics as user information may be mixed in.

A better solution would be to have some shared parsing functionality between the frontend server and Flutter tools like in a shared package.

@srujzs srujzs added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler
Projects
None yet
Development

No branches or pull requests

1 participant