Merge pull request #2831 from codablock/pr_v13_release

[0.13.x] Bump version to 0.13.3.0 and add release notes

Author: codablock

configure.ac

@@ -2,7 +2,7 @@ dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
 AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 0)
 define(_CLIENT_VERSION_MINOR, 13)
-define(_CLIENT_VERSION_REVISION, 2)
+define(_CLIENT_VERSION_REVISION, 3)
 define(_CLIENT_VERSION_BUILD, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)
 define(_COPYRIGHT_YEAR, 2018)

doc/Doxyfile

@@ -41,7 +41,7 @@ PROJECT_NAME           = "Dash Core"
 # could be handy for archiving the generated documentation or if some version
 # control system is used.
 
-PROJECT_NUMBER         = 0.13.2.0
+PROJECT_NUMBER         = 0.13.3.0
 
 # Using the PROJECT_BRIEF tag one can provide an optional one line description
 # for a project that appears at the top of each page and should give viewer a

doc/release-notes.md

@@ -1,4 +1,4 @@
-Dash Core version 0.13.2.0
+Dash Core version 0.13.3.0
 ==========================
 
 Release is now available from:
@@ -25,9 +25,9 @@ dashd/dash-qt (on Linux). If you upgrade after DIP0003 activation you will
 have to reindex (start with -reindex-chainstate or -reindex) to make sure
 your wallet has all the new data synced (only if you were using version < 0.13).
 
-Note that there is no protocol bump in this version and thus active masternodes
-updating from v0.13.0.0 or v0.13.1.0 do not require any additional actions (no need to issue
-`masternode start` command).
+As spork15 has been activated on mainnet, there is no need for `masternode start`
+anymore. Upgrading a masternode now only involves replacing binaries and restarting
+the node.
 
 Downgrade warning
 -----------------
@@ -37,95 +37,62 @@ Downgrade warning
 Downgrading to a version smaller than 0.13 is not supported anymore as DIP2/DIP3 has activated
 on mainnet and testnet.
 
-### Downgrade to 0.13.0.0 or 0.13.1.0
+### Downgrade to a version < 0.13.3.0
 
-Downgrading to 0.13.0.0 is fully supported but is not recommended unless you have some serious issues with 0.13.2.0.
+Downgrading to previous 0.13 releases is fully supported but is not recommended unless you have some serious issues with 0.13.3.0.
 
 Notable changes
 ===============
 
-Providing "masternodeblsprivkey" is now mandatory when the node is launched as a masternode ("masternode=1")
-------------------------------------------------------------------------
-In previous versions, "masternodeblsprivkey" was not mandatory as these versions had to function with and without DIP3
-activation. Now that DIP3 has activated on mainnet and testnet, we can make "masternodeblsprivkey" mandatory when
-configuring and running a masternode. Please note that your masternode will fail to start when "masternodeblsprivkey"
-is not specified. This also means that 0.13.2.0 will only work with masternodes which have already registered their
-DIP3 masternode. This enforcement was added to catch misconfigurations of masternodes which would otherwise stay
-unnoticed until spork 15 activation and thus surprise and hurt masternode owners.
-
-Fix for consistency issues after sudden stopping of node
---------------------------------------------------------
-Previous versions resulted in inconsistency between the chainstate and evodb when the node crashed or otherwise suddenly
-stopped (e.g. power failure). This should be fixed in 0.13.2.0. 
-
-Fix for litemode nodes to not reject specific DIP3 transactions
----------------------------------------------------------------
-Previous versions might cause litemode nodes to reject the mainnet chain after spork 15 activation. This is due to a
-consensus rule being less strict in one specific case when spork 15 is active. Litemode nodes can not know about the
-change in consensus rules as they have no knowledge about sporks. In 0.13.2.0, when litemode is enabled, we default to the
-behaviour of activated spork15 in this specific case, which fixes the issue. The restriction will be completely removed
-in the next major release.
-
-Fix incorrect behavior for "protx diff" and the P2P message "GETMNLISTDIFF"
----------------------------------------------------------------------------
-Both were responding with errors when "0" was used as base block hash. DIP4 defines "0" to be equivalent with the
-genesis block, so that it's easy for peers to request the full masternode list.
-This is mostly important for SPV nodes (e.g. mobile wallets) which need the masternode list. Right now, all nodes in
-the network will respond with an error when "0" is provided in  "GETMNLISTDIFF". Until enough masternodes have upgraded
-to 0.13.2.0, SPV nodes should use the full genesis hash to circumvent the error.
-
-Exclusion of LLMQ quorum commitments from partial blocks
---------------------------------------------------------
-SPV nodes are generally not interested in non-financial special transactions in blocks, so we're omitting them now when
-sending partial/filtered blocks to SPV clients. This currently only filters LLMQ quorum commitments, which also caused
-some SPV implementations to ban nodes as they were not able to process these. DIP3 transactions (ProRegTx, ProUpRegTx, ...)
-are not affected and are still included in partial/filtered blocks as these might also move funds. 
-
-RPC changes
------------
-`masternode list json` and `protx list` will now include the collateral address of masternodes.
+Number of false-positives from anti virus software should be reduced
+--------------------------------------------------------------------
+We have removed all mining code from Windows and Mac binaries, which should avoid most of the false-positive alerts
+from anti virus software. Linux builds are not affected. The mining code found in `dash-qt` and `dashd` are only meant
+for regression/integration tests and devnets, so there is no harm in removing this code from non-linux builds.
+
+Fixed an issue with invalid merkle blocks causing SPV nodes to ban other nodes
+------------------------------------------------------------------------------
+A fix that was introduces in the last minor version caused creation of invalid merkle blocks, which in turn cause SPV
+nodes to ban 0.13.2 nodes. This can be observed on mobile clients which have troubles maintaining connections. This
+release fixes this issue and should allow SPV/mobile clients to sync with upgraded nodes.
+
+Hardened spork15 value to 1047200
+---------------------------------
+We've hardened the spork15 block height to 1047200, which makes sure that syncing from scratch will always work, no
+matter if spork15 is received in-time or not.
 
 Bug fixes/Other improvements
 ----------------------------
 There are few bug fixes in this release:
-- Fixed a crash on shutdown
-- Fixed a misleading error message in the RPC "protx update_registrar"  
-- Slightly speed up initial sync by not running DIP3 logic in old blocks
-- Add build number (CLIENT_VERSION_BUILD) to MacOS bundle information 
+- Fixed an issue with transaction sometimes not being fully zapped when `-zapwallettxes` is used
+- Fixed an issue with the `protx revoke` RPC and REASON_CHANGE_OF_KEYS
 
- 0.13.2.0 Change log
+ 0.13.3.0 Change log
 ===================
 
-See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.13.1.0...dashpay:v0.13.2.0).
+See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.13.2.0...dashpay:v0.13.3.0).
 
 ### Backports
 
-- [`548a48918`](https://github.com/dashpay/dash/commit/548a48918) Move IS block filtering into ConnectBlock (#2766)
-- [`6374dce99`](https://github.com/dashpay/dash/commit/6374dce99) Fix error message for invalid voting addresses (#2747)
-- [`25222b378`](https://github.com/dashpay/dash/commit/25222b378) Make -masternodeblsprivkey mandatory when -masternode is given (#2745)
-- [`0364e033a`](https://github.com/dashpay/dash/commit/0364e033a) Implement 2-stage commit for CEvoDB to avoid inconsistencies after crashes (#2744)
-- [`a11e2f9eb`](https://github.com/dashpay/dash/commit/a11e2f9eb) Add collateraladdress into masternode/protx list rpc output (#2740)
-- [`43612a272`](https://github.com/dashpay/dash/commit/43612a272) Only include selected TX types into CMerkleBlock (#2737)
-- [`f868fbc78`](https://github.com/dashpay/dash/commit/f868fbc78) Stop g_connman first before deleting it (#2734)
-- [`9e233f391`](https://github.com/dashpay/dash/commit/9e233f391) Fix incorrect usage of begin() when genesis block is requested in "protx diff" (#2699)
-- [`e75f971b9`](https://github.com/dashpay/dash/commit/e75f971b9) Do not process blocks in CDeterministicMNManager before dip3 activation (#2698)
-- [`1cc47ebcd`](https://github.com/dashpay/dash/commit/1cc47ebcd) Backport #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (#2687)
+- [`575cafc01`](https://github.com/dashpay/dash/commit/575cafc01) Do not skip pushing of vMatch and vHashes in CMerkleBlock (#2826)
+- [`8c58799d8`](https://github.com/dashpay/dash/commit/8c58799d8) There can be no two votes which differ by the outcome only (#2819)
+- [`66c2f3953`](https://github.com/dashpay/dash/commit/66c2f3953) Fix vote ratecheck (#2813)
+- [`b52d0ad19`](https://github.com/dashpay/dash/commit/b52d0ad19) Fix revoke reason check for ProUpRevTx (#2787)
+- [`35914e084`](https://github.com/dashpay/dash/commit/35914e084) Skip mempool.dat when wallet is starting in "zap" mode (#2782)
+- [`46d875100`](https://github.com/dashpay/dash/commit/46d875100) Disable in-wallet miner for win/macos Travis/Gitian builds (#2778)
 
 ### Other
 
-- [`2516a6e19`](https://github.com/dashpay/dash/commit/2516a6e19) Bump version to 0.13.2
-- [`9dd16cdbe`](https://github.com/dashpay/dash/commit/9dd16cdbe) Bump minChainWork and AssumeValid to block #1033120 (#2750)
-- [`18f087b27`](https://github.com/dashpay/dash/commit/18f087b27) Fix some typos in doc/guide-startmany.md (#2711)
-- [`709ab6d3e`](https://github.com/dashpay/dash/commit/709ab6d3e) Minimal fix for litemode vs bad-protx-key-not-same issue (#2694)
+- [`25038ff36`](https://github.com/dashpay/dash/commit/25038ff36) Bump version to 0.13.3.0
+- [`53b2162e2`](https://github.com/dashpay/dash/commit/53b2162e2) Harden spork15 value to 1047200 when on mainnet (#2830)
 
 Credits
 =======
 
 Thanks to everyone who directly contributed to this release:
 
 - Alexander Block (codablock)
-- Felix Yan (felixonmars)
-- PastaPastaPasta
+- gladcow
 - UdjinM6
 
 As well as everyone that submitted issues and reviewed pull requests.
@@ -153,6 +120,7 @@ Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
 
 These release are considered obsolete. Old release notes can be found here:
 
+- [v0.13.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.2.0.md) released Mar/15/2019
 - [v0.13.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.1.0.md) released Feb/9/2019
 - [v0.13.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.0.0.md) released Jan/14/2019
 - [v0.12.3.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.4.md) released Dec/14/2018