Skip to content

Commit a884f0c

Browse files
PastaPastaPastaPastaPastaPasta
authored
Merge pull request #5506 from UdjinM6/backport_19.3_candidates
[v19.x] Backport 19.3 candidates, v19.3.0 release notes and version bump
2 parents 549e347 + 1c81bdd commit a884f0c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

90 files changed

+6436
-198
lines changed

‎configure.ac

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
AC_PREREQ([2.69])
22
define(_CLIENT_VERSION_MAJOR, 19)
3-
define(_CLIENT_VERSION_MINOR, 2)
3+
define(_CLIENT_VERSION_MINOR, 3)
44
define(_CLIENT_VERSION_BUILD, 0)
55
define(_CLIENT_VERSION_RC, 0)
66
define(_CLIENT_VERSION_IS_RELEASE, true)

‎doc/release-notes.md

+28-69
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Dash Core version v19.2.0
1+
# Dash Core version v19.3.0
22

33
Release is now available from:
44

@@ -7,8 +7,7 @@ Release is now available from:
77
This is a new minor version release, bringing various bugfixes and other
88
improvements.
99

10-
This release is mandatory for all nodes. This release resolves issues around the
11-
v19 Hard Fork activation. All nodes must upgrade to continue syncing properly.
10+
This release is optional for all nodes.
1211

1312
Please report bugs using the issue tracker at GitHub:
1413

@@ -27,15 +26,6 @@ using version < 0.13 you will have to reindex (start with -reindex-chainstate
2726
or -reindex) to make sure your wallet has all the new data synced. Upgrading
2827
from version 0.13 should not require any additional actions.
2928

30-
At the first startup Dash Core will run a migration process which can take
31-
anywhere from a few minutes to thirty minutes to finish. After the migration,
32-
a downgrade to an older version is only possible with a reindex.
33-
34-
Please note that seamless migration is only possible on nodes which did not
35-
reach the v19 fork block. Nodes that reached it can either rewind a couple
36-
of blocks back to a pre-v19 block using `invalidateblock` RPC while still
37-
running the old version or they can reindex instead.
38-
3929
## Downgrade warning
4030

4131
### Downgrade to a version < v19.2.0
@@ -46,79 +36,47 @@ reindex or re-sync the whole chain.
4636

4737
# Notable changes
4838

49-
## Resolve v19 Hard Fork Issues
50-
51-
One of the goals for the v19 Hard Fork was to activate basic BLS scheme and
52-
start using it in various on-chain and p2p messages. The motivation behind this
53-
change is the need to be aligned with IETF standards. Unfortunately, a few edge
54-
cases were missed in our functional tests and were not caught on testnet either.
55-
v19 activation attempt on mainnet hit one of these edge cases and mainnet
56-
stopped producing blocks. As an intermediate solution v19.1.0 was released which
57-
delayed the start of the signaling for the v19 Hard Fork until June 14th.
58-
59-
To resolve these issues we had to rework the way BLS public keys are handled
60-
including the way they are serialized in the internal database. This made it
61-
incompatible with older versions of Dash Core, so a db migration path was
62-
implemented for all recent versions.
63-
64-
## Improve migration and historical data support on light clients
65-
66-
As a side-effect, the solution implemented to resolve v19 Hard Fork issues
67-
opened a path to simplify v19 migration for mobile wallets.
68-
69-
With previous implementation mobile wallets would have to convert 4k+ pubkeys
70-
at the v19 fork point and that can easily take 10-15 seconds if not more.
71-
Also, after the v19 Hard Fork, if a masternode list is requested from a block
72-
before the v19 Hard Fork, the operator keys were coming in basic BLS scheme,
73-
but the masternode merkleroot hash stored in coinbase transaction at that time
74-
was calculated with legacy BLS scheme. Hence it was impossible to verify the
75-
merkleroot hash.
39+
## CoinJoin improvements
7640

77-
To fix these issues a new field `nVersion` was introduced for every entry in
78-
`mnlistdiff` p2p message. This field indicates which BLS scheme should be used
79-
when deserialising the message - legacy or basic. `nVersion` of the `mnlistdiff`
80-
message itself will no longer indicate the scheme and must always be set to `1`.
41+
This release fixes a couple of issues with mixing on nodes that start with no
42+
wallet loaded initially.
8143

82-
## Improve mixing support on light clients
44+
## Wallet GUI improvements
8345

84-
Recent changes to `dsq` and `dstx` messages allowed mobile clients that get
85-
masternode lists from `mnlistdiff` message to determine the masternode related
86-
to these messages because the `proTxHash` was used instead of the
87-
`masternodeOutpoint`. Once the v19 Hard Fork activates the signature of `dsq`
88-
and `dstx` messages will be based on the `proTxHash` which should make it
89-
possible for mobile clients to verify it.
46+
Wallets with 100k+ txes should now be able to rescan without hanging forever
47+
while processing notifications for every tx. Running `keypoolrefill` with a
48+
large number of keys will no longer lockup the GUI and can be interrupted.
49+
Running `upgradetohd` can also be interrupted now.
9050

91-
## Allow keeping Chainlocks enabled without signing new ones
51+
## Changes in RPCs, commands and config options
9252

93-
Before this version Chainlocks were either enabled or disabled. Starting with
94-
this version it's possible to set `SPORK_19_CHAINLOCKS_ENABLED` to a non-zero
95-
value to disable the signing of new Chainlocks while still enforcing the best
96-
known one.
53+
- `wipewallettxes`: New RPC command which removes all wallet transactions
54+
- `wipetxes`: New command for `dash-wallet` that removes all wallet transactions
55+
- `masternodelist`: New mode `hpmn` filters only HPMNs/EvoNodes
56+
- `protx list`: New type `hpmn` filters only HPMNs/EvoNodes
57+
- `-blockversion` config option is allowed on non-mainnet networks now
9758

9859
## Other changes
9960

10061
There were a few other minor changes too, specifically:
101-
- reindex on DB corruption should now start properly in Qt
102-
- a mnemonic passphrase longer than 256 symbols no longer crashes the wallet
103-
- a Qt node running with `-disablewawllet` flag should not crash in Settings now
104-
- `-masternodeblsprivkey` and `-sporkkey` values are no longer printed in
105-
`debug.log`
106-
- should use less memory in the long run comparing to older versions
107-
- gmp library detection should work better on macos
108-
- fixed a couple of typos
62+
- Added Kittywhiskers Van Gogh (kittywhiskers) and Odysseas Gabrielides
63+
(ogabrielides) to contributors list in 19.2.0 release notes
64+
- There should be no false "unknown rules activated" warning in GUI and RPCs now
65+
- Empty `settings.json` file no longer results in node startup failure
66+
- Block processing was slightly optimized
67+
- BLS library was updated to version 1.3.0 to fix a couple tiny issues
68+
- Fixed a couple of small issues in tests
10969

110-
# v19.2.0 Change log
70+
# v19.3.0 Change log
11171

112-
See detailed [set of changes](https://github.com/dashpay/dash/compare/v19.1.0...dashpay:v19.2.0).
72+
See detailed [set of changes](https://github.com/dashpay/dash/compare/v19.2.0...dashpay:v19.3.0).
11373

11474
# Credits
11575

11676
Thanks to everyone who directly contributed to this release:
11777

118-
- Konstantin Akimov (knst)
119-
- Nathan Marley (nmarley)
78+
- Odysseas Gabrielides (ogabrielides)
12079
- PastaPastaPasta
121-
- thephez
12280
- UdjinM6
12381

12482
As well as everyone that submitted issues, reviewed pull requests and helped
@@ -146,7 +104,8 @@ Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
146104

147105
These release are considered obsolete. Old release notes can be found here:
148106

149-
- [v19.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.0.0.md) released May/22/2023
107+
- [v19.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.2.0.md) released June/19/2023
108+
- [v19.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.1.0.md) released May/22/2023
150109
- [v19.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.0.0.md) released Apr/14/2023
151110
- [v18.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.2.md) released Mar/21/2023
152111
- [v18.2.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.1.md) released Jan/17/2023

‎doc/release-notes/dash/release-notes-19.2.0.md

+189
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,189 @@
1+
# Dash Core version v19.2.0
2+
3+
Release is now available from:
4+
5+
<https://www.dash.org/downloads/#wallets>
6+
7+
This is a new minor version release, bringing various bugfixes and other
8+
improvements.
9+
10+
This release is mandatory for all nodes. This release resolves issues around the
11+
v19 Hard Fork activation. All nodes must upgrade to continue syncing properly.
12+
13+
Please report bugs using the issue tracker at GitHub:
14+
15+
<https://github.com/dashpay/dash/issues>
16+
17+
18+
# Upgrading and downgrading
19+
20+
## How to Upgrade
21+
22+
If you are running an older version, shut it down. Wait until it has completely
23+
shut down (which might take a few minutes for older versions), then run the
24+
installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or
25+
dashd/dash-qt (on Linux). If you upgrade after DIP0003 activation and you were
26+
using version < 0.13 you will have to reindex (start with -reindex-chainstate
27+
or -reindex) to make sure your wallet has all the new data synced. Upgrading
28+
from version 0.13 should not require any additional actions.
29+
30+
At the first startup Dash Core will run a migration process which can take
31+
anywhere from a few minutes to thirty minutes to finish. After the migration,
32+
a downgrade to an older version is only possible with a reindex.
33+
34+
Please note that seamless migration is only possible on nodes which did not
35+
reach the v19 fork block. Nodes that reached it can either rewind a couple
36+
of blocks back to a pre-v19 block using `invalidateblock` RPC while still
37+
running the old version or they can reindex instead.
38+
39+
## Downgrade warning
40+
41+
### Downgrade to a version < v19.2.0
42+
43+
Downgrading to a version older than v19.2.0 is not supported due to changes
44+
in the evodb database. If you need to use an older version, you must either
45+
reindex or re-sync the whole chain.
46+
47+
# Notable changes
48+
49+
## Resolve v19 Hard Fork Issues
50+
51+
One of the goals for the v19 Hard Fork was to activate basic BLS scheme and
52+
start using it in various on-chain and p2p messages. The motivation behind this
53+
change is the need to be aligned with IETF standards. Unfortunately, a few edge
54+
cases were missed in our functional tests and were not caught on testnet either.
55+
v19 activation attempt on mainnet hit one of these edge cases and mainnet
56+
stopped producing blocks. As an intermediate solution v19.1.0 was released which
57+
delayed the start of the signaling for the v19 Hard Fork until June 14th.
58+
59+
To resolve these issues we had to rework the way BLS public keys are handled
60+
including the way they are serialized in the internal database. This made it
61+
incompatible with older versions of Dash Core, so a db migration path was
62+
implemented for all recent versions.
63+
64+
## Improve migration and historical data support on light clients
65+
66+
As a side-effect, the solution implemented to resolve v19 Hard Fork issues
67+
opened a path to simplify v19 migration for mobile wallets.
68+
69+
With previous implementation mobile wallets would have to convert 4k+ pubkeys
70+
at the v19 fork point and that can easily take 10-15 seconds if not more.
71+
Also, after the v19 Hard Fork, if a masternode list is requested from a block
72+
before the v19 Hard Fork, the operator keys were coming in basic BLS scheme,
73+
but the masternode merkleroot hash stored in coinbase transaction at that time
74+
was calculated with legacy BLS scheme. Hence it was impossible to verify the
75+
merkleroot hash.
76+
77+
To fix these issues a new field `nVersion` was introduced for every entry in
78+
`mnlistdiff` p2p message. This field indicates which BLS scheme should be used
79+
when deserialising the message - legacy or basic. `nVersion` of the `mnlistdiff`
80+
message itself will no longer indicate the scheme and must always be set to `1`.
81+
82+
## Improve mixing support on light clients
83+
84+
Recent changes to `dsq` and `dstx` messages allowed mobile clients that get
85+
masternode lists from `mnlistdiff` message to determine the masternode related
86+
to these messages because the `proTxHash` was used instead of the
87+
`masternodeOutpoint`. Once the v19 Hard Fork activates the signature of `dsq`
88+
and `dstx` messages will be based on the `proTxHash` which should make it
89+
possible for mobile clients to verify it.
90+
91+
## Allow keeping Chainlocks enabled without signing new ones
92+
93+
Before this version Chainlocks were either enabled or disabled. Starting with
94+
this version it's possible to set `SPORK_19_CHAINLOCKS_ENABLED` to a non-zero
95+
value to disable the signing of new Chainlocks while still enforcing the best
96+
known one.
97+
98+
## Other changes
99+
100+
There were a few other minor changes too, specifically:
101+
- reindex on DB corruption should now start properly in Qt
102+
- a mnemonic passphrase longer than 256 symbols no longer crashes the wallet
103+
- a Qt node running with `-disablewawllet` flag should not crash in Settings now
104+
- `-masternodeblsprivkey` and `-sporkkey` values are no longer printed in
105+
`debug.log`
106+
- should use less memory in the long run comparing to older versions
107+
- gmp library detection should work better on macos
108+
- fixed a couple of typos
109+
110+
# v19.2.0 Change log
111+
112+
See detailed [set of changes](https://github.com/dashpay/dash/compare/v19.1.0...dashpay:v19.2.0).
113+
114+
# Credits
115+
116+
Thanks to everyone who directly contributed to this release:
117+
118+
- Kittywhiskers Van Gogh (kittywhiskers)
119+
- Konstantin Akimov (knst)
120+
- Nathan Marley (nmarley)
121+
- Odysseas Gabrielides (ogabrielides)
122+
- PastaPastaPasta
123+
- thephez
124+
- UdjinM6
125+
126+
As well as everyone that submitted issues, reviewed pull requests and helped
127+
debug the release candidates.
128+
129+
# Older releases
130+
131+
Dash was previously known as Darkcoin.
132+
133+
Darkcoin tree 0.8.x was a fork of Litecoin tree 0.8, original name was XCoin
134+
which was first released on Jan/18/2014.
135+
136+
Darkcoin tree 0.9.x was the open source implementation of masternodes based on
137+
the 0.8.x tree and was first released on Mar/13/2014.
138+
139+
Darkcoin tree 0.10.x used to be the closed source implementation of Darksend
140+
which was released open source on Sep/25/2014.
141+
142+
Dash Core tree 0.11.x was a fork of Bitcoin Core tree 0.9,
143+
Darkcoin was rebranded to Dash.
144+
145+
Dash Core tree 0.12.0.x was a fork of Bitcoin Core tree 0.10.
146+
147+
Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
148+
149+
These release are considered obsolete. Old release notes can be found here:
150+
151+
- [v19.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.0.0.md) released May/22/2023
152+
- [v19.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.0.0.md) released Apr/14/2023
153+
- [v18.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.2.md) released Mar/21/2023
154+
- [v18.2.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.1.md) released Jan/17/2023
155+
- [v18.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.0.md) released Jan/01/2023
156+
- [v18.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.1.md) released January/08/2023
157+
- [v18.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.0.md) released October/09/2022
158+
- [v18.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.2.md) released October/09/2022
159+
- [v18.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.1.md) released August/17/2022
160+
- [v0.17.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.17.0.3.md) released June/07/2021
161+
- [v0.17.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.17.0.2.md) released May/19/2021
162+
- [v0.16.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.1.md) released November/17/2020
163+
- [v0.16.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.0.md) released November/14/2020
164+
- [v0.16.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.0.1.md) released September/30/2020
165+
- [v0.15.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.15.0.0.md) released Febrary/18/2020
166+
- [v0.14.0.5](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.5.md) released December/08/2019
167+
- [v0.14.0.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.4.md) released November/22/2019
168+
- [v0.14.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.3.md) released August/15/2019
169+
- [v0.14.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.2.md) released July/4/2019
170+
- [v0.14.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.1.md) released May/31/2019
171+
- [v0.14.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.md) released May/22/2019
172+
- [v0.13.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.3.md) released Apr/04/2019
173+
- [v0.13.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.2.md) released Mar/15/2019
174+
- [v0.13.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.1.md) released Feb/9/2019
175+
- [v0.13.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.0.md) released Jan/14/2019
176+
- [v0.12.3.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.4.md) released Dec/14/2018
177+
- [v0.12.3.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.3.md) released Sep/19/2018
178+
- [v0.12.3.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.2.md) released Jul/09/2018
179+
- [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018
180+
- [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018
181+
- [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017
182+
- [v0.12.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.md) released Nov/08/2017
183+
- [v0.12.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.1.md) released Feb/06/2017
184+
- [v0.12.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.0.md) released Aug/15/2015
185+
- [v0.11.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.2.md) released Mar/04/2015
186+
- [v0.11.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.1.md) released Feb/10/2015
187+
- [v0.11.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.0.md) released Jan/15/2015
188+
- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014
189+
- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014

‎src/bitcoin-wallet.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ static void SetupWalletToolArgs(ArgsManager& argsman)
3131

3232
// Hidden
3333
argsman.AddArg("salvage", "Attempt to recover private keys from a corrupt wallet", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
34+
argsman.AddArg("wipetxes", "Wipe all transactions from a wallet", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS);
3435
}
3536

3637
static bool WalletAppInit(int argc, char* argv[])

0 commit comments

Comments
 (0)