Skip to content

Commit 28f1dbf

Browse files
authored
Merge pull request #346 from ev-br/spec_cases_rm_cumprod
MAINT: always skip test_nan_propagation[cumulative_prod]
2 parents 2ffb924 + 2f8c1c0 commit 28f1dbf

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

array-api-strict-skips.txt

+1-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ array_api_tests/test_special_cases.py::test_iop[__ipow__(x1_i is -0 and x2_i > 0
77
# (https://github.com/data-apis/array-api-tests/issues/168)
88
array_api_tests/test_statistical_functions.py::test_sum
99

10-
# 2024.12 new failures, investigate
10+
# Stubs have a comment: (**note**: libraries may return ``NaN`` to match Python behavior.); Apparently, all libraries do just that
1111
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i > 0) -> +infinity]
1212
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is +infinity and isfinite(x2_i) and x2_i < 0) -> -infinity]
1313
array_api_tests/test_special_cases.py::test_binary[floor_divide(x1_i is -infinity and isfinite(x2_i) and x2_i > 0) -> -infinity]
@@ -27,6 +27,3 @@ array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(x1_i is -infinity
2727
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i > 0 and x2_i is -infinity) -> -0]
2828
array_api_tests/test_special_cases.py::test_iop[__ifloordiv__(isfinite(x1_i) and x1_i < 0 and x2_i is +infinity) -> -0]
2929

30-
# 2024.12 new failure, ndim=0 not allowed in cumulative_prod
31-
array_api_tests/test_special_cases.py::test_nan_propagation[cumulative_prod]
32-

array_api_tests/test_special_cases.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1332,7 +1332,7 @@ def test_empty_arrays(func_name, expected): # TODO: parse docstrings to get exp
13321332

13331333
@pytest.mark.parametrize(
13341334
"func_name", [f.__name__ for f in category_to_funcs["statistical"]
1335-
if f.__name__ != 'cumulative_sum']
1335+
if f.__name__ not in ['cumulative_sum', 'cumulative_prod']]
13361336
)
13371337
@given(
13381338
x=hh.arrays(dtype=hh.real_floating_dtypes, shape=hh.shapes(min_side=1)),

0 commit comments

Comments
 (0)