Skip to content

Support parsing special cases for 2022.12/draft that we already test for in 2021.12! #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
honno opened this issue Nov 23, 2023 · 2 comments · Fixed by #216
Closed

Support parsing special cases for 2022.12/draft that we already test for in 2021.12! #215

honno opened this issue Nov 23, 2023 · 2 comments · Fixed by #216
Assignees
@honno
Labels
enhancement New feature or request

Comments

@honno
Copy link
Member

honno commented Nov 23, 2023

After #213, it's not even that we can't parse newly introduced special cases, but that some changes to formatting mean special cases we test for 2021.12 aren't getting tested for >2022.12 now.
@honno honno added the enhancement New feature or request label Nov 23, 2023
@honno honno self-assigned this Nov 23, 2023
@kgryte
Copy link

kgryte commented Nov 23, 2023

What changes to formatting affected special case parsing?

@honno honno mentioned this issue Nov 24, 2023
Merged
@honno
Copy link
Member Author

honno commented Nov 24, 2023

What changes to formatting affected special case parsing?

Good questions... turns out, none! I just introduced a bug when collecting special cases (used break over continue 🤦), resolved by #216.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honno honno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix collection of special cases for >2022.12 honno/array-api-tests
2 participants
@kgryte @honno