🐞 Drop STJ source generation for now

Revert this once reactiveui/ReactiveUI#4019 is merged and out in a release.

Author: database64128

YoutubeDl.Wpf/Models/Settings.cs

@@ -1,6 +1,8 @@
 using MaterialDesignThemes.Wpf;
 using System;
 using System.ComponentModel;
+using System.Text.Encodings.Web;
+using System.Text.Json;
 using System.Threading;
 using System.Threading.Tasks;
 using YoutubeDl.Wpf.Utils;
@@ -95,14 +97,23 @@ public class Settings
 
     public string[] DownloadPathHistory { get; set; } = [];
 
+    private static readonly JsonSerializerOptions s_jsonSerializerOptions = new()
+    {
+        AllowTrailingCommas = true,
+        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
+        IgnoreReadOnlyProperties = true,
+        ReadCommentHandling = JsonCommentHandling.Skip,
+        WriteIndented = true,
+    };
+
     /// <summary>
     /// Loads settings from Settings.json.
     /// </summary>
     /// <param name="cancellationToken">A token that may be used to cancel the read operation.</param>
     /// <returns>The <see cref="Settings"/> object.</returns>
     public static async Task<Settings> LoadAsync(CancellationToken cancellationToken = default)
     {
-        var settings = await FileHelper.LoadFromJsonFileAsync("Settings.json", SettingsJsonSerializerContext.Default.Settings, cancellationToken).ConfigureAwait(false);
+        Settings settings = await FileHelper.LoadFromJsonFileAsync<Settings>("Settings.json", s_jsonSerializerOptions, cancellationToken).ConfigureAwait(false);
         settings.Update();
         settings.Validate();
         return settings;
@@ -114,7 +125,7 @@ public static async Task<Settings> LoadAsync(CancellationToken cancellationToken
     /// <param name="cancellationToken">A token that may be used to cancel the write operation.</param>
     /// <returns>A task that represents the asynchronous write operation.</returns>
     public Task SaveAsync(CancellationToken cancellationToken = default)
-        => FileHelper.SaveToJsonFileAsync("Settings.json", this, SettingsJsonSerializerContext.Default.Settings, cancellationToken);
+        => FileHelper.SaveToJsonFileAsync("Settings.json", this, s_jsonSerializerOptions, cancellationToken);
 
     /// <summary>
     /// Updates settings to the latest version.

YoutubeDl.Wpf/Models/SettingsJsonSerializerContext.cs

@@ -53,6 +53,27 @@ static FileHelper()
         }
     }
 
+    /// <summary>
+    /// Loads the specified JSON file and deserializes its content as a <typeparamref name="TValue"/>.
+    /// </summary>
+    /// <typeparam name="TValue">The type to deserialize the JSON value into.</typeparam>
+    /// <param name="path">JSON file path.</param>
+    /// <param name="jsonSerializerOptions">Deserialization options.</param>
+    /// <param name="cancellationToken">A token that may be used to cancel the read operation.</param>
+    /// <returns>A <typeparamref name="TValue"/>.</returns>
+    public static async Task<TValue> LoadFromJsonFileAsync<TValue>(string path, JsonSerializerOptions? jsonSerializerOptions = null, CancellationToken cancellationToken = default) where TValue : class, new()
+    {
+        path = GetAbsolutePath(path);
+        if (!File.Exists(path))
+            return new();
+
+        var fileStream = new FileStream(path, FileMode.Open);
+        await using (fileStream.ConfigureAwait(false))
+        {
+            return await JsonSerializer.DeserializeAsync<TValue>(fileStream, jsonSerializerOptions, cancellationToken).ConfigureAwait(false) ?? new();
+        }
+    }
+
     /// <summary>
     /// Serializes the provided value as JSON and saves to the specified file.
     /// </summary>
@@ -89,4 +110,41 @@ public static async Task SaveToJsonFileAsync<TValue>(
         if (canReplace)
             File.Replace(newPath, path, $"{path}.old");
     }
+
+    /// <summary>
+    /// Serializes the provided value as JSON and saves to the specified file.
+    /// </summary>
+    /// <typeparam name="TValue">The type of the value to serialize.</typeparam>
+    /// <param name="path">JSON file path.</param>
+    /// <param name="value">The value to save.</param>
+    /// <param name="jsonSerializerOptions">Serialization options.</param>
+    /// <param name="cancellationToken">A token that may be used to cancel the write operation.</param>
+    /// <returns>A task that represents the asynchronous write operation.</returns>
+    public static async Task SaveToJsonFileAsync<TValue>(
+        string path,
+        TValue value,
+        JsonSerializerOptions? jsonSerializerOptions = null,
+        CancellationToken cancellationToken = default)
+    {
+        path = GetAbsolutePath(path);
+
+        var directoryPath = Path.GetDirectoryName(path);
+        if (string.IsNullOrEmpty(directoryPath))
+            throw new ArgumentException("Invalid path.", nameof(path));
+
+        _ = Directory.CreateDirectory(directoryPath);
+
+        // File.Replace throws an exception when the destination file does not exist.
+        var canReplace = File.Exists(path);
+        var newPath = canReplace ? $"{path}.new" : path;
+        var fileStream = new FileStream(newPath, FileMode.Create);
+
+        await using (fileStream.ConfigureAwait(false))
+        {
+            await JsonSerializer.SerializeAsync(fileStream, value, jsonSerializerOptions, cancellationToken);
+        }
+
+        if (canReplace)
+            File.Replace(newPath, path, $"{path}.old");
+    }
 }