Skip to content

Fix issue wherein nested type in complex data type is missing in thrift response metadata #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix issue wherein nested type in complex data type is missing in thrift response metadata #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
362ac93
palantir-fix
madhav-db Nov 24, 2025
0c5bbd5
changelog
madhav-db Nov 24, 2025
61159bd
changelog
madhav-db Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .metals/index.mbt
View file
Open in desktop
Binary file not shown.
Binary file added .metals/lib/java-header-compiler.jar
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions .metals/metals.lock.db
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#FileLock
#Mon Nov 24 05:40:50 UTC 2025
server=localhost\:35435
hostName=localhost
method=file
id=19ab4610c5198cfeb03e946dc3b7631a8f0e8d9f478
Binary file added .metals/metals.mv.db
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
### Updated

### Fixed

- Fixed: Thrift Responses involving complex data types now have detailed nested type information.
---
*Note: When making changes, please add your change under the appropriate section with a brief description.*
8 changes: 8 additions & 0 deletions src/main/java/com/databricks/jdbc/api/impl/DatabricksResultSetMetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,14 @@ public DatabricksResultSetMetaData(
int precision = precisionAndScale[0];
int scale = precisionAndScale[1];

// Use arrowMetadata for type text if available, as it contains full type information
String columnTypeText =
(arrowMetadata != null
&& columnIndex < arrowMetadata.size()
&& arrowMetadata.get(columnIndex) != null)
? arrowMetadata.get(columnIndex)
: getTypeTextFromTypeDesc(columnDesc.getTypeDesc());

ImmutableDatabricksColumn.Builder columnBuilder = getColumnBuilder();
// Use arrowMetadata for type text if available, as it contains full type information
// like "ARRAY<INT>" whereas TTypeDesc only has primitive "ARRAY_TYPE"
Expand Down
Loading