refactor: replace c() default in-favour of NULL#179
Closed
m-muecke wants to merge 1 commit into
Closed
Conversation
`c()` evaluates to `NULL` and `NULL` is more clear. Otherwise, `character()` might be a better default signaling empty character vector and being type safe.
Collaborator
|
this was originally deliberate to signal that it can take a vector of values without reading the docs. Your not wrong, i just don't think this change makes a large diff either way at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c()evaluates toNULLandNULLis more clear. Otherwise,character()might be a better default signaling empty character vector and being type safe.