Skip to content

test(datahub-schematron): update golden diff to fix schema translation test #14132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vinayakhulawale
Copy link
Contributor

Updated expected difference by using mce_diff.py script.

Before change :

Gradle suite > Gradle test > io.datahubproject.schematron.SchemaTranslatorTest > testSchemaTranslations[2](src/test/resources/CustomerProfile.avsc) FAILED
    java.lang.AssertionError: Outputs differ for CustomerProfile.avsc expected [0] but found [1]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:1419)
        at org.testng.Assert.assertEquals(Assert.java:1383)
        at io.datahubproject.schematron.SchemaTranslatorTest.compareTranslations(SchemaTranslatorTest.java:147)
        at io.datahubproject.schematron.SchemaTranslatorTest.testSchemaTranslations(SchemaTranslatorTest.java:54)

3 tests completed, 1 failed

[Incubating] Problems report is available at: file:///Users/vinayakhulawale/projects/datahub/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':metadata-integration:java:datahub-schematron:cli:test'.
> There were failing tests. See the report at: file:///Users/vinayakhulawale/projects/datahub/metadata-integration/java/datahub-schematron/cli/build/reports/tests/test/index.html

* Try:
> Run with --scan to get full insights.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.14.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 2m 15s
74 actionable tasks: 72 executed, 2 up-to-date

after change :


Gradle suite > Gradle test > io.datahubproject.schematron.SchemaTranslatorTest > testSchemaTranslations[2](src/test/resources/CustomerProfile.avsc) PASSED

[Incubating] Problems report is available at: file:///Users/vinayakhulawale/projects/datahub/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.14.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 11s
75 actionable tasks: 28 executed, 47 up-to-date

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jul 17, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 17, 2025
@yoonhyejin yoonhyejin self-requested a review July 18, 2025 07:24
Copy link
Collaborator

@yoonhyejin yoonhyejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, nice catch!

@yoonhyejin yoonhyejin merged commit 1df3da5 into datahub-project:master Jul 18, 2025
22 checks passed
@chakru-r chakru-r added this to the v1.2.0 milestone Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants