Use APScheduler

Author: BenjaminCharmes

pydatalab/tests/server/test_export.py

@@ -27,8 +27,6 @@ def sample_collection(database, user_id):
 
 @pytest.fixture
 def mock_scheduler():
-    """Mock the APScheduler to run jobs synchronously for testing."""
-
     with patch("pydatalab.routes.v0_1.export.export_scheduler") as mock_scheduler:
         mock_scheduler.add_job = MagicMock()
 
@@ -40,43 +38,34 @@ def mock_add_job(func, args, job_id=None):
         yield mock_scheduler
 
 
-@pytest.fixture
-def mock_current_user():
-    """Mock the current user for testing."""
-    with patch("pydatalab.routes.v0_1.export.current_user") as mock_user:
-        mock_person = MagicMock()
-        mock_person.immutable_id = "test_user_id"
-        mock_user.person = mock_person
-        mock_user.is_authenticated = True
-        yield mock_user
-
-
 class TestExportRoutes:
     def test_start_collection_export_success(self, client, sample_collection, mock_scheduler):
         collection_id = sample_collection["collection_id"]
 
-        response = client.post(f"/collections/{collection_id}/export")
+        with patch("pydatalab.routes.v0_1.export.current_app") as mock_app:
+            mock_app._get_current_object.return_value = MagicMock()
 
-        assert response.status_code == 202
+            response = client.post(f"/collections/{collection_id}/export")
 
-        data = json.loads(response.data)
-        assert data["status"] == "success"
-        assert "task_id" in data
-        assert "status_url" in data
-        assert data["status_url"] == f"/exports/{data['task_id']}/status"
+            assert response.status_code == 202
+
+            data = json.loads(response.data)
+            assert data["status"] == "success"
+            assert "task_id" in data
+            assert "status_url" in data
+            assert data["status_url"] == f"/exports/{data['task_id']}/status"
 
-        assert mock_scheduler.add_job.called
+            assert mock_scheduler.add_job.called
 
     def test_start_collection_export_not_found(self, client):
         response = client.post("/collections/nonexistent/export")
-        assert response.status_code == 403
+        assert response.status_code == 404
 
         data = json.loads(response.data)
         assert data["status"] == "error"
-        assert "not found" in data["message"].lower() or "access denied" in data["message"].lower()
+        assert "not found" in data["message"].lower()
 
     def test_get_export_status_pending(self, client, database):
-        """Test getting status of pending export task."""
         task_id = "test-task-pending"
         task = ExportTask(
             task_id=task_id,
@@ -96,7 +85,6 @@ def test_get_export_status_pending(self, client, database):
         database.export_tasks.delete_one({"task_id": task_id})
 
     def test_get_export_status_ready(self, client, database, tmp_path):
-        """Test getting status of completed export task."""
         task_id = "test-task-ready"
         file_path = tmp_path / f"{task_id}.eln"
         file_path.write_text("test content")
@@ -122,7 +110,6 @@ def test_get_export_status_ready(self, client, database, tmp_path):
         database.export_tasks.delete_one({"task_id": task_id})
 
     def test_get_export_status_error(self, client, database):
-        """Test getting status of failed export task."""
         task_id = "test-task-error"
         error_message = "Export failed due to test error"
 
@@ -147,7 +134,6 @@ def test_get_export_status_error(self, client, database):
         database.export_tasks.delete_one({"task_id": task_id})
 
     def test_get_export_status_not_found(self, client):
-        """Test getting status of non-existent export task."""
         response = client.get("/exports/nonexistent-task/status")
         assert response.status_code == 404
 
@@ -156,7 +142,6 @@ def test_get_export_status_not_found(self, client):
         assert "not found" in data["message"].lower()
 
     def test_download_export_success(self, client, database, tmp_path):
-        """Test downloading completed export file."""
         task_id = "test-download-task"
         collection_id = "test_collection"
         file_path = tmp_path / f"{task_id}.eln"
@@ -179,7 +164,6 @@ def test_download_export_success(self, client, database, tmp_path):
         database.export_tasks.delete_one({"task_id": task_id})
 
     def test_download_export_not_ready(self, client, database):
-        """Test downloading export that's not ready."""
         task_id = "test-not-ready-task"
 
         task = ExportTask(
@@ -199,7 +183,6 @@ def test_download_export_not_ready(self, client, database):
         database.export_tasks.delete_one({"task_id": task_id})
 
     def test_download_export_file_missing(self, client, database):
-        """Test downloading export when file is missing."""
         task_id = "test-missing-file-task"
 
         task = ExportTask(