Skip to content

Added .csv option to echem block and bumped navani version number #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added .csv option to echem block and bumped navani version number #1397

wants to merge 2 commits into from

Conversation

@be-smith
Copy link
Contributor

@be-smith be-smith commented Nov 4, 2025 •
edited by ml-evs
Loading

Closes #1377

@be-smith be-smith marked this pull request as ready for review November 4, 2025 09:58
@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.14%. Comparing base (5920ede) to head (1420959).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files          70       70           
  Lines        4799     4799           
=======================================
  Hits         3846     3846           
  Misses        953      953
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/echem/blocks.py 76.22% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Nov 4, 2025

datalab    Run #4031

Run Properties:  status check passed Passed #4031  •  git commit 841c8783e6 ℹ️: Merge 14209595152eee9b7831d26feb85b68f37749343 into 5920ede8f9bbe3574bef6f2e31d7...
Project datalab
Branch Review bes/echem_csv
Run status status check passed Passed #4031
Run duration 07m 37s
Commit git commit 841c8783e6 ℹ️: Merge 14209595152eee9b7831d26feb85b68f37749343 into 5920ede8f9bbe3574bef6f2e31d7...
Committer Ben Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

ml-evs
ml-evs reviewed Nov 4, 2025
View reviewed changes
pydatalab/src/pydatalab/apps/echem/blocks.py
Copy link
Member

@ml-evs ml-evs Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand the docstring to 1) talk about navani, 2) briefly describe formats/cycler brands that the file extensions pertain to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ml-evs ml-evs ml-evs left review comments

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add .csv support to CycleBlock for preprocessed data

3 participants

@be-smith @ml-evs