Add block for processing GPC/SEC data from Agilent Technologies 1260 Infinity II multidetector SEC/GPC system #1409
Conversation
isabelcooley
requested review from
BenjaminCharmes,
jdbocarsly and
ml-evs
as code owners
be-smith
left a comment
be-smith
left a comment
There was a problem hiding this comment.
This is really great and it works for me well! I couldn't make changes to your fork so I have pushed my own branch #1413. The comments I left are the only slight changes I made other than those done by the precommit, but they are just for formatting the labels to be consistent for the absorption mode.
| if xunits == 'default': | ||
| toollabsx = "Wavenumber / cm⁻¹" | ||
| else: | ||
| toollabsx = "Wavenumber /{0}".format(xunits) |
There was a problem hiding this comment.
Added a space between the / and the unit. This is just to keep it consistent with other datalab blocks.
| toollabsx = "Wavenumber /{0}".format(xunits) | |
| toollabsx = "Wavenumber / {0}".format(xunits) |
| # Adding cm^-1 to the x-axis label using unicode characters - might be a more logical way | ||
| layout.children[1].xaxis.axis_label = "Wavenumber / cm⁻¹" | ||
| else: | ||
| layout.children[1].xaxis.axis_label = "Wavenumber /{0}".format(xunits) |
There was a problem hiding this comment.
| layout.children[1].xaxis.axis_label = "Wavenumber /{0}".format(xunits) | |
| layout.children[1].xaxis.axis_label = "Wavenumber / {0}".format(xunits) |
| if xunits == 'default': | ||
| # Adding cm^-1 to the x-axis label using unicode characters - might be a more logical way | ||
| layout.children[1].xaxis.axis_label = "Wavenumber / cm⁻¹" | ||
| else: |
There was a problem hiding this comment.
I just made this change so that the label appears the same with a superscript as in the other mode.
| else: | |
| elif xunits == "1/CM\n": | |
| layout.children[1].xaxis.axis_label = "Wavenumber / cm⁻¹" | |
| else: |
| toollabsx = "Wavenumber /{0}".format(xunits) | ||
| if yunits == 'default': | ||
| toollabsy = "Absorbance" | ||
| else: |
There was a problem hiding this comment.
Changed the unit to display a superscript like in the other format
| else: | |
| elif xunits == "1/CM\n": | |
| toollabsx = "Wavenumber / cm⁻¹" | |
| else: |
There was a problem hiding this comment.
I don't think we want to include this in the PR, I think the gitignore should've caught it but I can remove it from the other branch.
Merge with base datalab
Block reads .xlsx files from an Agilent Technologies 1260 Infinity II multidetector SEC/GPC system and: - Plots the response trace, with options to show slice region(s) for peaks, indicate the retention time of the flow marker (if information is present), and show the regions indicating the baseline - Has option to plot two response traces on different y axes if more than one is present in the file - Presents molecular weight data from the file in a table - Optionally plots the calibration curve for the region over which it was measured
isabelcooley
changed the title
3 participants
Block can read .txt files form a Shimadzu IR Tracer-100 FT-IR spectrophotometer (can't read the spectrometer's proprietary .ispd format)