Minor improvements to the XRD-insitu block front end #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 70 70
Lines 4836 4836
=======================================
Hits 3871 3871
Misses 965 965 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/XRD_insitu_improvements
|
| Run status |
|
| Run duration | 07m 41s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
354
|
| View all changes introduced in this branch ↗︎ | |
be-smith
requested review from
BenjaminCharmes,
jdbocarsly and
ml-evs
as code owners
ml-evs
force-pushed
the
bes/XRD_insitu_improvements
branch
from
e925242 to
9e61224
Compare
ml-evs
reviewed
Nov 11, 2025
Member
ml-evs
left a comment
ml-evs
left a comment
There was a problem hiding this comment.
Please bump the version number of the plugin here after merging the LDE PR
BenjaminCharmes
previously approved these changes
Nov 11, 2025
Contributor
BenjaminCharmes
left a comment
BenjaminCharmes
left a comment
There was a problem hiding this comment.
LGTM, working great!
For consistency purposes, I think we should refactor this in a future PR to:
- Use Popper.js (like
StyledBlockInfoandStyledBlockHelp) instead of the nativetitleattribute, which has a slower delay (~1s) and doesn't match our UI styling - Add hover effects on the info icon (color transition)
- Use
cursor: pointerinstead ofcursor: helpfor consistency
Even better would be to create a generic HelpTooltip component that could be reused throughout the app and potentially replace the similar logic in StyledBlockInfo and StyledBlockHelp.
ml-evs
force-pushed
the
bes/XRD_insitu_improvements
branch
from
d355857 to
3032cd9
Compare
ml-evs
approved these changes
Nov 12, 2025
Member
ml-evs
left a comment
ml-evs
left a comment
There was a problem hiding this comment.
Let's merge this and implement @BenjaminCharmes's suggestions in a future PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added info hover panels to data granularity and sample granularity. Added a box for File pattern so supply glob_str to the backend for matching patterns in the files. (E.g "summed" to grab all the summed mythen files for XRD data).
Default behaviour if nothing is added to File pattern is to match all files.