Skip to content

fix: return typed values from scss functions instead of strings #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfranzke merged 7 commits into from
Dec 5, 2025
+12 −2
Merged

fix: return typed values from scss functions instead of strings #5570

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e8017cb
Initial plan
Copilot Dec 4, 2025
215b928
fix: px-to-rem() and px-to-em() now return proper values instead of s…
Copilot Dec 4, 2025
3840087
Merge branch 'main' into copilot/fix-px-to-rem-function
mfranzke Dec 4, 2025
be975b7
Create heavy-spiders-check.md
mfranzke Dec 4, 2025
8914149
Update dependencies to patch versions
mfranzke Dec 4, 2025
46027e9
Update heavy-spiders-check.md
mfranzke Dec 4, 2025
7631383
Merge branch 'main' into copilot/fix-px-to-rem-function
mfranzke Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/heavy-spiders-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@db-ux/core-components": patch
"@db-ux/ngx-core-components": patch
"@db-ux/react-core-components": patch
"@db-ux/wc-core-components": patch
"@db-ux/v-core-components": patch
---

fix(SASS): return typed values from scss functions instead of strings
4 changes: 2 additions & 2 deletions packages/foundations/scss/helpers/_functions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
@use "clearfix";

@function px-to-rem($pxValue) {
@return #{$pxValue * 0.0625}rem;
@return ($pxValue * 0.0625) * 1rem;
}

@function px-to-em($pxValue) {
@return #{$pxValue * 0.0625}em;
@return ($pxValue * 0.0625) * 1em;
}

$cursor-pointer: var(--db-overwrite-cursor, pointer);
Expand Down