Buffer handling fixes

rlerdorf · rlerdorf · commit f5980b7a4cee · 2009-07-16T00:06:08.000Z
diff --git a/ext/interbase/interbase.c b/ext/interbase/interbase.c
@@ -861,8 +861,8 @@ static char const dpb_args[] = {
 	
 int _php_ibase_attach_db(char **args, int *len, long *largs, isc_db_handle *db TSRMLS_DC)
 {
-	short i, dpb_len, buf_len = 256;
-	char dpb_buffer[256] = { isc_dpb_version1 }, *dpb;
+	short i, dpb_len, buf_len = 257-2;  /* version byte at the front, and a null at the end */
+	char dpb_buffer[257] = { isc_dpb_version1, 0 }, *dpb;
 
 	dpb = dpb_buffer + 1;
 

Original file line number	Diff line number	Diff line change
`@@ -861,8 +861,8 @@ static char const dpb_args[] = {`
`861`	`861`
`862`	`862`	`int _php_ibase_attach_db(char *args, int len, long largs, isc_db_handle db TSRMLS_DC)`
`863`	`863`	`{`
`864`		`- short i, dpb_len, buf_len = 256;`
`865`		`- char dpb_buffer[256] = { isc_dpb_version1 }, *dpb;`
	`864`	`+ short i, dpb_len, buf_len = 257-2; /* version byte at the front, and a null at the end */`
	`865`	`+ char dpb_buffer[257] = { isc_dpb_version1, 0 }, *dpb;`
`866`	`866`
`867`	`867`	`dpb = dpb_buffer + 1;`
`868`	`868`