Skip to content

Implement blob downloading #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dbrgn merged 3 commits into from
Dec 24, 2022
Merged

Implement blob downloading #65

dbrgn merged 3 commits into from
Dec 24, 2022

Conversation

@dbrgn
Copy link
Owner

@dbrgn dbrgn commented Dec 24, 2022 •
edited
Loading

Extracted from #62.

Updates:

  • The download method did not yet check the response code. Error responses were returned as blob contents, which is wrong.
  • Added some docs
  • Added an example for download_blob
  • Applied rustfmt

CC @Shorty1o1

@dbrgn dbrgn self-assigned this Dec 24, 2022
@dbrgn dbrgn merged commit d43f313 into master Dec 24, 2022
@dbrgn dbrgn deleted the blob-download branch December 24, 2022 15:50
@dbrgn dbrgn mentioned this pull request Dec 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dbrgn dbrgn

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dbrgn @Shorty1o1