Fix partial parsing bug with singular tests #12224
Merged
+67
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12223
Problem
The change in #12055 (backported to v1.10.14 in #12060) is missing a guard on the type of a test when attempting to partial parse.
GenericTestshaveattached_nodeattributes, butSingularTestsdo not.Solution
Similar to other cases in the codebase (
dbt-core/core/dbt/parser/manifest.py
Line 1575 in cb7c4a7
GenericTestsonly.I've included a test case which fails under the old code, and shows the issue is resolved by the change.
Checklist