Skip to content

Commit d53a6e1

Browse files
authored
fix: wrong type annotation in for saved_queries (#46)
The sync client had an `async` method in its type annotations, which probably got there by my fast copy pasting. This commit fixes that.
1 parent 39b6f91 commit d53a6e1

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kind: Fixes
2+
body: Fixed wrong annotation for `saved_queries` in sync client.
3+
time: 2024-09-20T20:25:58.362587+02:00

dbtsl/client/sync.pyi

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class SyncSemanticLayerClient:
4242
"""Get a list of all available entities for a given set of metrics."""
4343
...
4444

45-
async def saved_queries(self) -> List[SavedQuery]:
45+
def saved_queries(self) -> List[SavedQuery]:
4646
"""Get a list of all available saved queries."""
4747
...
4848

tests/integration/test_sl_client.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,9 @@ async def test_client_works_multiple(subtests: SubTests, client: BothClients) ->
7272
dim_values = await maybe_await(client.dimension_values(metrics=[metric.name], group_by=dimension.name))
7373
assert len(dim_values) > 0
7474

75-
76-
async def test_client_lists_saved_queries(client: BothClients) -> None:
77-
sqs = await maybe_await(client.saved_queries())
78-
assert len(sqs) > 0
75+
with subtests.test("saved_queries"):
76+
sqs = await maybe_await(client.saved_queries())
77+
assert len(sqs) > 0
7978

8079

8180
@pytest.mark.parametrize("api", [ADBC, GRAPHQL])

0 commit comments

Comments
 (0)