Update delete calls to directly use delete response without parsing

Signed-off-by: Daniel Widdis <[email protected]>

Author: dbwiddis

plugin/src/main/java/org/opensearch/ml/action/agents/DeleteAgentTransportAction.java

@@ -186,7 +186,7 @@ private void handleDeleteResponse(
             actionListener.onFailure(cause);
         } else {
             try {
-                DeleteResponse deleteResponse = DeleteResponse.fromXContent(response.parser());
+                DeleteResponse deleteResponse = response.deleteResponse();
                 log.info("Agent deletion result: {}, agent id: {}", deleteResponse.getResult(), response.id());
                 actionListener.onResponse(deleteResponse);
             } catch (Exception e) {

plugin/src/main/java/org/opensearch/ml/action/connector/DeleteConnectorTransportAction.java

@@ -8,7 +8,6 @@
 import static org.opensearch.ml.common.CommonValue.ML_CONNECTOR_INDEX;
 import static org.opensearch.ml.common.CommonValue.ML_MODEL_INDEX;
 
-import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -221,10 +220,10 @@ private void handleDeleteResponse(
             actionListener.onFailure(cause);
         } else {
             try {
-                DeleteResponse deleteResponse = DeleteResponse.fromXContent(response.parser());
+                DeleteResponse deleteResponse = response.deleteResponse();
                 log.info("Connector deletion result: {}, connector id: {}", deleteResponse.getResult(), response.id());
                 actionListener.onResponse(deleteResponse);
-            } catch (IOException e) {
+            } catch (Exception e) {
                 actionListener.onFailure(e);
             }
         }

plugin/src/main/java/org/opensearch/ml/action/model_group/DeleteModelGroupTransportAction.java

@@ -9,8 +9,6 @@
 import static org.opensearch.ml.common.CommonValue.ML_MODEL_INDEX;
 import static org.opensearch.ml.utils.RestActionUtils.PARAMETER_MODEL_GROUP_ID;
 
-import java.io.IOException;
-
 import org.opensearch.ExceptionsHelper;
 import org.opensearch.OpenSearchStatusException;
 import org.opensearch.action.ActionRequest;
@@ -211,10 +209,10 @@ private void handleDeleteResponse(
             actionListener.onFailure(cause);
         } else {
             try {
-                DeleteResponse deleteResponse = DeleteResponse.fromXContent(response.parser());
+                DeleteResponse deleteResponse = response.deleteResponse();
                 log.debug("Completed Delete Model Group Request, model group id:{} deleted", response.id());
                 actionListener.onResponse(deleteResponse);
-            } catch (IOException e) {
+            } catch (Exception e) {
                 actionListener.onFailure(e);
             }
         }

plugin/src/main/java/org/opensearch/ml/action/models/DeleteModelTransportAction.java

@@ -332,7 +332,7 @@ private void deleteModel(
         sdkClient.deleteDataObjectAsync(deleteDataObjectRequest).whenComplete((r, throwable) -> {
             if (throwable == null) {
                 try {
-                    DeleteResponse deleteResponse = DeleteResponse.fromXContent(r.parser());
+                    DeleteResponse deleteResponse = r.deleteResponse();
                     deleteModelChunksAndController(actionListener, modelId, functionName, isHidden, deleteResponse);
                 } catch (Exception e) {
                     actionListener.onFailure(e);

plugin/src/main/java/org/opensearch/ml/action/tasks/DeleteTaskTransportAction.java

@@ -9,8 +9,6 @@
 import static org.opensearch.core.xcontent.XContentParserUtils.ensureExpectedToken;
 import static org.opensearch.ml.common.CommonValue.ML_TASK_INDEX;
 
-import java.io.IOException;
-
 import org.opensearch.ExceptionsHelper;
 import org.opensearch.OpenSearchStatusException;
 import org.opensearch.action.ActionRequest;
@@ -192,10 +190,10 @@ private void handleDeleteError(Throwable throwable, String taskId, ActionListene
 
     private void processDeleteResponse(DeleteDataObjectResponse deleteDataObjectResponse, ActionListener<DeleteResponse> actionListener) {
         try {
-            DeleteResponse deleteResponse = DeleteResponse.fromXContent(deleteDataObjectResponse.parser());
+            DeleteResponse deleteResponse = deleteDataObjectResponse.deleteResponse();
             log.info("Task deletion result: {}, task id: {}", deleteResponse.getResult(), deleteResponse.getId());
             actionListener.onResponse(deleteResponse);
-        } catch (IOException e) {
+        } catch (Exception e) {
             actionListener.onFailure(e);
         }
     }