Skip to content

Commit 99ae3ed

Browse files
committed
Uncomment search-related tests now that searches are tenant aware
Signed-off-by: Daniel Widdis <[email protected]>
1 parent 4912c2b commit 99ae3ed

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

plugin/src/test/java/org/opensearch/ml/rest/RestMLAgentTenantAwareIT.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,10 +212,8 @@ public void testAgentCRUD() throws Exception {
212212
assertOK(restResponse);
213213
SearchResponse searchResponse = searchResponseFromResponse(restResponse);
214214
if (multiTenancyEnabled) {
215-
/*- TODO Currently failing because TransportSearchAgentAction is still using client.search()
216215
assertEquals(1, searchResponse.getHits().getTotalHits().value);
217216
assertEquals(tenantId, searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));
218-
*/
219217
} else {
220218
assertEquals(2, searchResponse.getHits().getTotalHits().value);
221219
assertNull(searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));
@@ -229,10 +227,8 @@ public void testAgentCRUD() throws Exception {
229227
assertOK(restResponse);
230228
SearchResponse searchResponse = searchResponseFromResponse(restResponse);
231229
if (multiTenancyEnabled) {
232-
/*- TODO Currently failing because TransportSearchAgentAction is still using client.search()
233230
assertEquals(1, searchResponse.getHits().getTotalHits().value);
234231
assertEquals(otherTenantId, searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));
235-
*/
236232
} else {
237233
assertEquals(2, searchResponse.getHits().getTotalHits().value);
238234
assertNull(searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));

plugin/src/test/java/org/opensearch/ml/rest/RestMLModelTenantAwareIT.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,8 @@ public void testModelCRUD() throws Exception {
226226
assertOK(restResponse);
227227
SearchResponse searchResponse = searchResponseFromResponse(restResponse);
228228
if (multiTenancyEnabled) {
229-
/*- TODO Currently failing because MLSearchHandler is still using client.search()
230229
assertEquals(1, searchResponse.getHits().getTotalHits().value);
231230
assertEquals(tenantId, searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));
232-
*/
233231
} else {
234232
assertEquals(3, searchResponse.getHits().getTotalHits().value);
235233
assertNull(searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));
@@ -243,10 +241,8 @@ public void testModelCRUD() throws Exception {
243241
assertOK(restResponse);
244242
SearchResponse searchResponse = searchResponseFromResponse(restResponse);
245243
if (multiTenancyEnabled) {
246-
/*- TODO Currently failing because MLSearchHandler is still using client.search()
247244
assertEquals(1, searchResponse.getHits().getTotalHits().value);
248245
assertEquals(otherTenantId, searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));
249-
*/
250246
} else {
251247
assertEquals(3, searchResponse.getHits().getTotalHits().value);
252248
assertNull(searchResponse.getHits().getHits()[0].getSourceAsMap().get(TENANT_ID_FIELD));

0 commit comments

Comments
 (0)