Update update calls to directly use update response without parsing

Signed-off-by: Daniel Widdis <[email protected]>

Author: dbwiddis

plugin/src/main/java/org/opensearch/ml/action/connector/UpdateConnectorTransportAction.java

@@ -9,7 +9,6 @@
 import static org.opensearch.ml.common.CommonValue.ML_MODEL_INDEX;
 import static org.opensearch.ml.settings.MLCommonsSettings.ML_COMMONS_TRUSTED_CONNECTOR_ENDPOINTS_REGEX;
 
-import java.io.IOException;
 import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -228,9 +227,8 @@ private void handleUpdateDataObjectCompletionStage(
             updateListener.onFailure(cause);
         } else {
             try {
-                UpdateResponse updateResponse = r.parser() == null ? null : UpdateResponse.fromXContent(r.parser());
-                updateListener.onResponse(updateResponse);
-            } catch (IOException e) {
+                updateListener.onResponse(r.updateResponse());
+            } catch (Exception e) {
                 updateListener.onFailure(e);
             }
         }

plugin/src/main/java/org/opensearch/ml/action/models/UpdateModelTransportAction.java

@@ -450,8 +450,7 @@ private void buildUpdateRequest(
         sdkClient.updateDataObjectAsync(updateDataObjectRequest).whenComplete((ur, ut) -> {
             if (ut == null) {
                 try {
-                    UpdateResponse updateResponse = ur.parser() == null ? null : UpdateResponse.fromXContent(ur.parser());
-                    updateListener.onResponse(updateResponse);
+                    updateListener.onResponse(ur.updateResponse());
                 } catch (Exception e) {
                     updateListener.onFailure(e);
                 }
@@ -503,8 +502,7 @@ private void buildUpdateRequest(
                 sdkClient.updateDataObjectAsync(updateDataObjectRequest).whenComplete((ur, ut) -> {
                     if (ut == null) {
                         try {
-                            UpdateResponse updateResponse = ur.parser() == null ? null : UpdateResponse.fromXContent(ur.parser());
-                            updateListener.onResponse(updateResponse);
+                            updateListener.onResponse(ur.updateResponse());
                         } catch (Exception e) {
                             updateListener.onFailure(e);
                         }

plugin/src/main/java/org/opensearch/ml/model/MLModelManager.java

@@ -55,7 +55,6 @@
 import static org.opensearch.ml.utils.MLNodeUtils.createXContentParserFromRegistry;
 
 import java.io.File;
-import java.io.IOException;
 import java.nio.file.Path;
 import java.security.PrivilegedActionException;
 import java.time.Instant;
@@ -2271,9 +2270,8 @@ private void handleUpdateDataObjectCompletionStage(
             updateListener.onFailure(cause);
         } else {
             try {
-                UpdateResponse updateResponse = r.parser() == null ? null : UpdateResponse.fromXContent(r.parser());
-                updateListener.onResponse(updateResponse);
-            } catch (IOException e) {
+                updateListener.onResponse(r.updateResponse());
+            } catch (Exception e) {
                 updateListener.onFailure(e);
             }
         }

plugin/src/main/java/org/opensearch/ml/task/MLTaskManager.java

@@ -505,9 +505,8 @@ private void handleUpdateDataObjectCompletionStage(
             updateListener.onFailure(cause);
         } else {
             try {
-                UpdateResponse updateResponse = r.parser() == null ? null : UpdateResponse.fromXContent(r.parser());
-                updateListener.onResponse(updateResponse);
-            } catch (IOException e) {
+                updateListener.onResponse(r.updateResponse());
+            } catch (Exception e) {
                 updateListener.onFailure(e);
             }
         }