Skip to content

[Dependency] Method layer depending back on source_esolver #7605

Description

@Critsium-xy

Describe the Code Quality Issue

  • Symptom: source_lcao/module_lr/esolver_lrtd_lcao.h includes esolver_fp.h, esolver_ks_lcao.h — the LR-TDDFT ESolver has been misplaced inside source_lcao.
  • Fix: move the ESolver parts of module_lr into source_esolver.
  • Acceptance: cut lcao → esolver.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions