Skip to content

Commit bbbc978

Browse files
committed
fix: continue_on_success_ratio without slice raise error
1 parent 0ab9b32 commit bbbc978

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/dflow/step.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,8 @@ def merge_output_artifact(art, parent, layer=0):
722722
self.template.set_slices(self.template.slices)
723723
self.with_param = argo_range(if_expression(
724724
"%s %% %s > 0" % (nslices, group_size),
725-
"%s/%s + 1" % (nslices, group_size),
725+
"(%s - %s %% %s) / %s + 1" % (nslices,
726+
nslices, group_size, group_size),
726727
"%s/%s" % (nslices, group_size)))
727728
elif self.with_param is not None:
728729
self.template.inputs.parameters["dflow_with_param"] = \
@@ -745,7 +746,8 @@ def merge_output_artifact(art, parent, layer=0):
745746
self.template.set_slices(self.template.slices)
746747
self.with_param = argo_range(if_expression(
747748
"%s %% %s > 0" % (nslices, group_size),
748-
"%s/%s + 1" % (nslices, group_size),
749+
"(%s - %s %% %s) / %s + 1" % (nslices,
750+
nslices, group_size, group_size),
749751
"%s/%s" % (nslices, group_size)))
750752
if self.with_sequence is not None:
751753
self.template.inputs.parameters["dflow_sequence_start"] = \
@@ -799,7 +801,8 @@ def merge_output_artifact(art, parent, layer=0):
799801
self.with_sequence = argo_sequence(
800802
count=if_expression(
801803
"%s %% %s > 0" % (nslices, group_size),
802-
"%s/%s + 1" % (nslices, group_size),
804+
"(%s - %s %% %s) / %s + 1" % (nslices,
805+
nslices, group_size, group_size),
803806
"%s/%s" % (nslices, group_size)), format=format)
804807

805808
self.inputs.parameters["dflow_nslices"] = InputParameter(
@@ -932,6 +935,7 @@ def add_success_tag(templ):
932935
}
933936
)
934937
elif self.continue_on_success_ratio is not None:
938+
total = 1
935939
if "dflow_nslices" in self.inputs.parameters:
936940
total = self.inputs.parameters["dflow_nslices"].value
937941
elif self.with_param is not None:

0 commit comments

Comments
 (0)