Skip to content

Conversation

@Amnah199
Copy link
Contributor

No description provided.

@Amnah199 Amnah199 requested a review from a team as a code owner September 25, 2025 13:14
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bilgeyucel bilgeyucel self-assigned this Oct 6, 2025
@Amnah199 Amnah199 requested a review from anakin87 December 2, 2025 13:35
@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Prerequisites: You must have an API key from an active OpenAI account as this tutorial is using the gpt-4o-mini model by OpenAI.

Since we are going to change default models, I would modify this sentence to be more generic


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colorama is no longer needed


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that other tutorials do not contain outputs for installation commands. Can we remove them?


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #3.    pip install "haystack-ai==2.20.0"

You mean >=2.20.0?


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, we are going to change default models.

If you want to use gpt-4o-mini, better to specify it in the init. Otherwise, make the above sentence more generic.


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Lets


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    responses_generator.run(messages=[ChatMessage.from_user(" Berlin is the capital of Germany. It has a population of 3,850,809. Paris, France's capital, has 2.161 million residents.")])

remove the initial space


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can we find info on the schema format? Add a link if possible.


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: paramter


Reply via ReviewNB

@@ -0,0 +1,591 @@
{
Copy link
Member

@anakin87 anakin87 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #3.    result = chat_generator.run(messages=[ChatMessage.from_user(" Berlin is the capital of Germany. It has a population of 3,850,809. Paris, France's capital, has 2.161 million residents.")])

remove the initial space


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants