Merge pull request #2 from delegateas/copilot/fix-1

Remove for, foreach, do, while from CT0001 analysis

Author: magesoe

README.md

@@ -4,7 +4,7 @@ A Roslyn analyzer for .NET Core projects that enforces specific control flow bra
 
 ## Rule CT0001: Control Flow Braces Rule
 
-This analyzer enforces that control flow statements without braces can only contain:
+This analyzer enforces that `if` and `else` control flow statements without braces can only contain:
 - `return` statements
 - `throw` statements  
 - `continue` statements
@@ -36,10 +36,6 @@ if (done)
 // This will trigger CT0001
 if (condition)
     DoSomething();
-
-// This will trigger CT0001  
-for (int i = 0; i < 10; i++)
-    x = i;
 ```
 
 ## Usage

src/DataverseAnalyzer/BracesForControlFlowAnalyzer.cs

@@ -27,10 +27,6 @@ public override void Initialize(AnalysisContext context)
         context.EnableConcurrentExecution();
         context.RegisterSyntaxNodeAction(AnalyzeIfStatement, SyntaxKind.IfStatement);
         context.RegisterSyntaxNodeAction(AnalyzeElseClause, SyntaxKind.ElseClause);
-        context.RegisterSyntaxNodeAction(AnalyzeForStatement, SyntaxKind.ForStatement);
-        context.RegisterSyntaxNodeAction(AnalyzeForEachStatement, SyntaxKind.ForEachStatement);
-        context.RegisterSyntaxNodeAction(AnalyzeWhileStatement, SyntaxKind.WhileStatement);
-        context.RegisterSyntaxNodeAction(AnalyzeDoStatement, SyntaxKind.DoStatement);
     }
 
     private static void AnalyzeIfStatement(SyntaxNodeAnalysisContext context)
@@ -48,30 +44,6 @@ private static void AnalyzeElseClause(SyntaxNodeAnalysisContext context)
         }
     }
 
-    private static void AnalyzeForStatement(SyntaxNodeAnalysisContext context)
-    {
-        var forStatement = (ForStatementSyntax)context.Node;
-        AnalyzeEmbeddedStatement(context, forStatement.Statement);
-    }
-
-    private static void AnalyzeForEachStatement(SyntaxNodeAnalysisContext context)
-    {
-        var forEachStatement = (ForEachStatementSyntax)context.Node;
-        AnalyzeEmbeddedStatement(context, forEachStatement.Statement);
-    }
-
-    private static void AnalyzeWhileStatement(SyntaxNodeAnalysisContext context)
-    {
-        var whileStatement = (WhileStatementSyntax)context.Node;
-        AnalyzeEmbeddedStatement(context, whileStatement.Statement);
-    }
-
-    private static void AnalyzeDoStatement(SyntaxNodeAnalysisContext context)
-    {
-        var doStatement = (DoStatementSyntax)context.Node;
-        AnalyzeEmbeddedStatement(context, doStatement.Statement);
-    }
-
     private static void AnalyzeEmbeddedStatement(SyntaxNodeAnalysisContext context, StatementSyntax statement)
     {
         if (statement is BlockSyntax)

tests/DataverseAnalyzer.Tests/BracesForControlFlowAnalyzerTests.cs

@@ -125,44 +125,6 @@ private void DoSomething() { }
         Assert.Equal("CT0001", diagnostics[0].Id);
     }
 
-    [Fact]
-    public async Task ForStatementWithAssignmentShouldTrigger()
-    {
-        var source = """
-            class TestClass
-            {
-                public void TestMethod()
-                {
-                    int x = 0;
-                    for (int i = 0; i < 10; i++)
-                        x = i;
-                }
-            }
-            """;
-
-        var diagnostics = await GetDiagnosticsAsync(source);
-        Assert.Single(diagnostics);
-        Assert.Equal("CT0001", diagnostics[0].Id);
-    }
-
-    [Fact]
-    public async Task WhileStatementWithReturnShouldNotTrigger()
-    {
-        var source = """
-            class TestClass
-            {
-                public void TestMethod()
-                {
-                    while (true)
-                        return;
-                }
-            }
-            """;
-
-        var diagnostics = await GetDiagnosticsAsync(source);
-        Assert.Empty(diagnostics);
-    }
-
     [Fact]
     public async Task IfStatementWithBracesShouldNotTrigger()
     {