Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Live Preview #33

Closed
DutchPete opened this issue Dec 21, 2021 · 19 comments
Closed

Add support for Live Preview #33

DutchPete opened this issue Dec 21, 2021 · 19 comments

Comments

@DutchPete
Copy link

This is a very useful plug-in. Unfortunately it does not work with Live Preview (code mirror6).
Could you add support for LP?

@uwe999
Copy link

uwe999 commented Dec 21, 2021

+1

2 similar comments
@ChengYingo
Copy link

+1

@MikhaD
Copy link
Contributor

MikhaD commented Dec 23, 2021

+1

@EhuddR
Copy link

EhuddR commented Dec 28, 2021

It's very useful indeed. Please add support for code mirror 6.

@InvisOn
Copy link

InvisOn commented Dec 28, 2021

It does not work at all anymore. Even with live preview turned off.

@walkinverse
Copy link

I also just hit this today with the new live preview. UGH. Please add support..

@DutchPete
Copy link
Author

The last release is dated 27 April: that is a long time ago. The dev has so far not reacted to the many comments or upvotes. I wonder if he/she has abandoned the plug-in?

@MikhaD
Copy link
Contributor

MikhaD commented Dec 31, 2021

If that is the case would people be in favor of me creating a new plugin that does the same thing and works in the latest version? You'd have to install it manually until its approved as a community plugin, but it would be better than nothing.

@DutchPete
Copy link
Author

If creating a new plug-in is easier than adapting the current one, sure. Manual installation is no big deal at all.

@krzemian
Copy link

krzemian commented Jan 1, 2022

@MikhaD would be great, as a workaround I can see that the current plugin exposes "Paste URL into selection:" in the command palette, which still works in Live Preview. So setting up a custom hotkey for pasting URLs only works for now.

@MikhaD
Copy link
Contributor

MikhaD commented Jan 4, 2022

Okay guys, I have created a pull request (#34 ) that fixes this plugin for the latest version with live preview. If you want to install it now you can download the main.js and manifest.json files from here.
Please let me know if you find any issues with it.

@DutchPete
Copy link
Author

I cannot load this via the BRAT plug-in - it says there is no manifest.json file, even though there is.

@badmuggle
Copy link

works great after installing files. thanks!

@DutchPete
Copy link
Author

I don't know if it is me but I reinstalled the plug-in from the community collection and it works. So, many thanks for that.

@About7Deaths
Copy link

About7Deaths commented Jan 22, 2022

Okay guys, I have created a pull request (#34 ) that fixes this plugin for the latest version with live preview. If you want to install it now you can download the main.js and manifest.json files from here. Please let me know if you find any issues with it.

The update works great, thanks for that. What is your plan for the future if the original developer does not return to the project? Additionally, would you be willing to implement the ability to paste regular non-formatted hyperlinks when using Ctrl + Shift + V if used instead of the standard Ctrl + V?

@InvisOn
Copy link

InvisOn commented Jan 23, 2022

An alternative to this seemingly abandoned plugin could be https://github.com/zolrath/obsidian-auto-link-title

@MikhaD
Copy link
Contributor

MikhaD commented Jan 23, 2022

Okay guys, I have created a pull request (#34 ) that fixes this plugin for the latest version with live preview. If you want to install it now you can download the main.js and manifest.json files from here. Please let me know if you find any issues with it.

The update works great, thanks for that. What is your plan for the future if the original developer does not return to the project? Additionally, would you be willing to implement the ability to paste regular non-formatted hyperlinks when using Ctrl + Shift + V if used instead of the standard Ctrl + V?

I would be happy to implement that. Hopefully the dev returns and accepts my pull request. I'm not sure what to do otherwise. Maybe there's a way for me to request that the link to this plugin in obsidian-releases is changed to point to my fork of the plugin?

@MikhaD
Copy link
Contributor

MikhaD commented Jan 26, 2022

The author has merged my pull request! He said there should be a release later today 🎉

@denolehov
Copy link
Owner

Thank you once again for your contribution @MikhaD! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests