New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifests API endpoint should always return valid JSON #1207

Open

pkarman opened this issue Mar 17, 2020 · 1 comment

Labels

Product: caseflow-eFolder-Express

Contributor

pkarman commented Mar 17, 2020

department-of-veterans-affairs/caseflow#13571

pkarman added the Product: caseflow-eFolder-Express label

Contributor Author

pkarman commented Jun 2, 2020

https://sentry.ds.va.gov/department-of-veterans-affairs/efolder/issues/7731/events/f97ac04978a14e6fa40d4f1c36d6a21a/

one timing coordinated example of failure with

https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/7118/events/ff37163c8a02431fb796311efab3013a/

seems to be EE is returning the HTML 500 page instead of a JSON error payload. I could not reproduce.

There is already global error handling with JSON response in https://github.com/department-of-veterans-affairs/caseflow-efolder/blob/master/app/controllers/api/v1/application_controller.rb#L5 so this must be happening through some other code path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment