Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external link variation [Development] #3303

Closed
3 tasks
danbrady opened this issue Sep 27, 2024 · 6 comments · Fixed by department-of-veterans-affairs/component-library#1396
Closed
3 tasks
Assignees
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-link DS Link

Comments

@danbrady
Copy link
Contributor

danbrady commented Sep 27, 2024

Description

See parent issue.

Per comments below: Keep the variation in Storybook but swap the icon for the "(opens in a new tab)" text.

Tasks

  • Replace va-link external variation icon with "(opens in a new tab)"
  • Update va-link and va-statement-of-truth tests as necessary

Acceptance Criteria

  • Existing in-prod uses of external va-link should not break upon update

Engineers:

Estimating

Provide your estimate of 1, 2, 3, 5, 8 or 13
@Andrew565 - 2
@ataker -
@harshil1793 -
@it-harrison - 2
@jamigibbs - 3
@micahchiang - 2
@powellkerry -
@rmessina1010 -
@rsmithadhoc -

@caw310 caw310 added the DST-engineering Issues that require work from Design System Team engineers label Sep 27, 2024
@caw310
Copy link
Contributor

caw310 commented Sep 27, 2024

@jamigibbs
Copy link
Contributor

I just want to callout that if we're removing the icon, we will probably need to update the va-statement-of-truth component too (maybe dev and definitely design/Figma)

Image

@rsmithadhoc
Copy link
Contributor

We will still need to support external links with the prop. So should we:

  1. Completely remove the variation from Storybook but swap the icon for the "(opens in a new tab)" text in the component.
  2. Keep the variation in Storybook but swap the icon for the "(opens in a new tab)" text.
  3. Remove the variation, remove the icon, and do not add the text to the component. Users of the component would add that themselves.

@jamigibbs
Copy link
Contributor

  1. Keep the variation in Storybook but swap the icon for the "(opens in a new tab)" text.

@rsmithadhoc I personally think 2. is the direction that makes sense.

Another thing to keep in mind is USWDS has an external link variation that uses an icon (which is what we modeled ours after).

@humancompanion-usds
Copy link
Collaborator

Yes, this is a deviation from USWDS. @rsmithadhoc weighed in earlier so #2 should be the option we are taking. Ryan - If you could drop some a11y guidance as to why we are deviating from the USWDS (which I'm fine with but we should documenet) that would be helpful to note in this variation of link. Thanks!

@rsmithadhoc
Copy link
Contributor

I added a note on the accessibility considerations here, but will hold off on merging until this is ready to avoid any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-engineering Issues that require work from Design System Team engineers platform-design-system-team va-link DS Link
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants