-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove external link variation [Development] #3303
Remove external link variation [Development] #3303
Comments
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rsmithadhoc |
I just want to callout that if we're removing the icon, we will probably need to update the va-statement-of-truth component too (maybe dev and definitely design/Figma) |
We will still need to support external links with the prop. So should we:
|
@rsmithadhoc I personally think Another thing to keep in mind is USWDS has an external link variation that uses an icon (which is what we modeled ours after). |
Yes, this is a deviation from USWDS. @rsmithadhoc weighed in earlier so #2 should be the option we are taking. Ryan - If you could drop some a11y guidance as to why we are deviating from the USWDS (which I'm fine with but we should documenet) that would be helpful to note in this variation of link. Thanks! |
I added a note on the accessibility considerations here, but will hold off on merging until this is ready to avoid any confusion. |
Description
See parent issue.
Per comments below: Keep the variation in Storybook but swap the icon for the "(opens in a new tab)" text.
Tasks
Acceptance Criteria
Engineers:
Estimating
Provide your estimate of 1, 2, 3, 5, 8 or 13
@Andrew565 - 2
@ataker -
@harshil1793 -
@it-harrison - 2
@jamigibbs - 3
@micahchiang - 2
@powellkerry -
@rmessina1010 -
@rsmithadhoc -
The text was updated successfully, but these errors were encountered: