Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y-defect-3]: Download benefit letters "Expand all" button should not have an aria-expanded attribute #96354

Open
2 of 18 tasks
1Copenut opened this issue Nov 1, 2024 · 2 comments · May be fixed by department-of-veterans-affairs/component-library#1400
Assignees
Labels
a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints accessibility benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2 design system

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Nov 1, 2024

Point of contact

Trevor Pierce

Severity level

3, Moderate. Should be fixed in 1-3 sprints post-launch.

Details

The VA Documents and Letters (step 2) view has an "Expand all" button for the accordions. This button has an aria-expanded attribute that doesn't make sense here because it's a control for multiple accordions, with text that updates to match its current state. Screenshot attached.


Image

Reproduction steps

  1. Log into https://staging.va.gov/records/download-va-letters/letters/letter-list with a test user who has benefit letters. I used user 54.
  2. Turn on the screen reader of your choice
  3. Tab to the "Expand all" button and listen for it to say "Expand all accordions, button, collapsed"
  4. Press Enter to expand the accordions
  5. Verify the button now says "Close all accordions, button, expanded"

Proposed solution or next steps

I'm proposing we remove the aria-expanded attribute from this button and just use the text to describe what action the button will take.

References, articles, or WCAG support

  1. Understanding SC 1.3.1: Info and Relationships (Level A)

Type of issue

  • Axe-core
  • Screenreader | assistive tech & device support
  • Keyboard
  • Zoom
  • Color, typography, & visual elements
  • Components and pattern standards
  • Content organization
  • Focus
  • Headings
  • Content style guide
  • Link and button labels
  • Semantic HTML
  • Markup and metadata
  • Non-text content and media
  • Overall user experience
  • Cognitive | user flows & navigating
  • URL standards
  • Something else
@1Copenut 1Copenut added accessibility a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2 labels Nov 1, 2024
@dysbo dysbo added the needs-refinement Identifies tickets that need to be refined label Nov 12, 2024
@1Copenut 1Copenut self-assigned this Nov 13, 2024
@1Copenut
Copy link
Contributor Author

@dysbo I'm grabbing this one off the backlog while I'm blocked on my other accessibility ticket. Should be a very quick win for us.

@1Copenut 1Copenut added design system and removed needs-refinement Identifies tickets that need to be refined labels Nov 13, 2024
@1Copenut
Copy link
Contributor Author

Turns out this is an upstream item in the VADS. I'll pivot and work in that repo to issue a patch fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints accessibility benefits-management-tools includes Claim Status Tool, Benefits Letters, Payment History bmt-team-2 Benefits Management Tools Team #2 design system
Projects
None yet
2 participants