Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire API Keys #2309

Open
6 tasks
EvanParish opened this issue Feb 12, 2025 · 3 comments
Open
6 tasks

Expire API Keys #2309

EvanParish opened this issue Feb 12, 2025 · 3 comments

Comments

@EvanParish
Copy link

EvanParish commented Feb 12, 2025

User Story - Business Need

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

With the current implementation API keys do not expire. Once we have switched our users to keys that do have an expiry date, we need to stop expired keys from authenticating.

User Story(ies)

As a backend engineer
I want API keys to expire when the expiry_date has passed
So that we can maintain a secure platform

Additional Info and Resources

  • Look for TODO 2309 for this work and adjust the code and tests accordingly.

Acceptance Criteria

  • Ensure all API keys in the database have an expiry_date assigned as this code is pushed up through the environments.
  • When an API key is used that is expired according to its expiry_date, then the request is rejected.
  • The warning logs associated with using expired or old-style keys should no longer be necessary after this update. They have been removed.
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

  • Ensure API keys that are expired, according to its expiry_date, are no longer usable to authenticate requests.

Potential Dependencies

This ticket can only be worked after all of the services are using the updated API keys. See the API Keys Epic for progress.

Out of Scope

Updating the API key GET route is out of scope if it has not been worked yet. The ticket api #2311 is for that purpose.

@cris-oddball
Copy link

@EvanParish please include in the Dependencies section that the checklist in the Epic needs to be completed before this is worked. Thank you!

@EvanParish
Copy link
Author

@cris-oddball Changes have been made.

@cris-oddball
Copy link

@EvanParish Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants