Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU - Update HandleTokenCallbackURL to a query instead of mutation and update getAuthSettings to getFirstTimeLogin and reduce redux state management. #10158

Open
Sparowhawk opened this issue Nov 12, 2024 · 0 comments
Labels
code upkeep front-end Ticket requires front-end work global Issues for the global team

Comments

@Sparowhawk
Copy link
Contributor

Comment are here #8192

But this ticket is to cover the work of updating handleTokenCallbackURL to a query instead of a mutation. Allowing us to get rid of the loginFinish and Start functions. It should also allow us to simplify the redux state management to handle some of the variables such as login, logout, loading, and syncing, by migrating those to the corresponding queries.

Once that is pulled out we can also change getAuthSettings to getFirstTimeLogin and have it return a boolean or combine it with the remaining state management stuff in the redux slice.

@Sparowhawk Sparowhawk added code upkeep front-end Ticket requires front-end work global Issues for the global team labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code upkeep front-end Ticket requires front-end work global Issues for the global team
Projects
None yet
Development

No branches or pull requests

1 participant