Merge remote-tracking branch 'upstream/main'

Author: JunTaoLuo

.github/ISSUE_TEMPLATE/pw-clp-request.md

@@ -25,6 +25,15 @@ Help desk ticket: <insert_help_desk_link>
 - [ ] Name of submitter (if applicable)
 Submitter: <insert_name>
 
+- Campaign title: 
+- Who the editor(s) will be for the Campaign Landing Page and any appropriate stakeholders for awareness: 
+- The goals/outcomes you are looking to achieve with the campaign: 
+- Outcome success measurement & how it will be measured (note: "Page views" is not a generally accepted success measurement): 
+- Target Audience(s): 
+-  Campaign start/end dates: 
+- Is this a seasonal campaign? 
+- If not: when campaign ends, should campaign page be archived or redirected? 
+- If redirected, where should it redirect?
 
 ## Acceptance criteria
 

.github/ISSUE_TEMPLATE/taxonomy-update-term.yml

@@ -75,5 +75,10 @@ body:
       - [ ] Content is reviewed by relevant stakeholders
       - [ ] (List any necessary review and approval steps here)
       - [ ] Term is published
+      If term is part of VA Service Taxonomy & the term name changes:
+      - [ ] Bulk resave system services to pick up name change (filtered for the old name)
+      - [ ] Bulk Update alias for all system services (filtered for new name)
+      - [ ] Bulk update facility services (filtered for the old name)
+      - [ ] Bulk update alias for all facility services (filtered for new name)
   validations:
     required: true

.github/workflows/actions-metrics.yml

@@ -11,7 +11,7 @@ jobs:
     timeout-minutes: 10
     steps:
       - name: Send GitHub Actions metrics to DataDog
-        uses: int128/datadog-actions-metrics@6c6a657047c0452b33ec3c254009c331e47c1370 # v1.64.0
+        uses: int128/datadog-actions-metrics@56be1c4bf92adece9d10f7fef4ba48bccf8e8c81 # v1.77.0
         with:
           datadog-api-key: ${{ secrets.DATADOG_API_KEY }}
           collect-job-metrics: true

.github/workflows/continuous_integration.yml

@@ -46,7 +46,7 @@ jobs:
         uses: ./.github/actions/post-checkout
       - name: ReviewDog
         # See also `composer va:test:eslint` in composer.json
-        uses: reviewdog/action-eslint@279acb08336462ec76183a2d9ef1dd43e4c6b391 # v1.21.0
+        uses: reviewdog/action-eslint@5deb8e2c1d8a9bbefff4d80d6702c41c5b3729cb # v1.22.0
         with:
           reporter: github-pr-review
           eslint_flags: '--max-warnings 0 -c .eslintrc.json --no-eslintrc docroot/modules/custom/**/*.es6.js docroot/themes/custom/**/*.es6.js tests/cypress/**/*.js'

.github/workflows/cypress.yml

@@ -47,7 +47,7 @@ jobs:
           NODE_TLS_REJECT_UNAUTHORIZED: 0
 
       - name: Cypress run
-        uses: cypress-io/github-action@ebe8b24c4428922d0f793a5c4c96853a633180e3 # v6.6.0
+        uses: cypress-io/github-action@1b70233146622b69e789ccdd4f9452adc638d25a # v6.6.1
         with:
           wait-on: "${{ inputs.preview_url }}"
           command: 'npm run test:cypress:parallel'

.github/workflows/tugboat-pr-closed.yml

@@ -12,7 +12,6 @@ jobs:
     name: Delete Tugboat Preview
     steps:
     - name: Dispatch Tugboat Preview Deletion
-      continue-on-error: true
       uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
       with:
         script: |

.github/workflows/tugboat-pr-opened.yml

@@ -13,7 +13,6 @@ jobs:
     name: Create Tugboat Preview
     steps:
     - name: Dispatch Tugboat Preview Creation
-      continue-on-error: true
       uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
       with:
         script: |

.github/workflows/tugboat-pr-updated.yml

@@ -12,7 +12,6 @@ jobs:
     name: Rebuild Tugboat Preview
     steps:
     - name: Dispatch Tugboat Preview Rebuild
-      continue-on-error: true
       uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
       with:
         script: |

.tugboat/config.yml

@@ -206,6 +206,7 @@ services:
 
         # Create symlink between vets-website assets and next-build
 #        - ln -snf "${DOCROOT}/vendor/va-gov/vets-website/build/localhost/generated" "${TUGBOAT_ROOT}/next/public/generated"
+        - mkdir -p "${TUGBOAT_ROOT}/next/public"
         - ln -snf "${TUGBOAT_ROOT}/vets-website/build/localhost/generated" "${TUGBOAT_ROOT}/next/public/generated"
 
 

.tugboat/vhost-next.conf

@@ -29,8 +29,8 @@
     # Ignore redirecting error doc directory
     ProxyPass /.next/ !
     # Redirect requests to the running node server from next-build
-    ProxyPass / http://localhost:3000/
-    ProxyPassReverse / http://localhost:3000/
+    ProxyPass / http://localhost:3999/
+    ProxyPassReverse / http://localhost:3999/
 
     # Available loglevels: trace8, ..., trace1, debug, info, notice, warn,
     # error, crit, alert, emerg.

READMES/devops/aws-assets.md

@@ -0,0 +1,18 @@
+# AWS Assets
+
+This is a list of some generic AWS assets that are not directly traceable to this team, i.e. they are not managed in Terraform or other IaC. The purpose of this document is to clarify ownership and collect relevant information so that these assets are more discoverable and their _raison d'être_ more transparent.
+
+## IAM Users (Service Accounts)
+
+The following were added in #5611 to work with certain S3 buckets; these are intended to allow transfer of files from CMS file stores to an S3 bucket designated for public access to those files. These systems are not fully in place yet, but are in progress.
+
+- `svc-dsva-vagov-cms-dev-assets` 
+- `svc-dsva-vagov-prod-cms-files`
+- `svc-dsva-vagov-prod-cms-test-files`
+- `svc-dsva-vagov-staging-cms-files`
+- `svc-dsva-vagov-staging-cms-test-files`
+
+The following account may be necessary for GitHub Actions workflows (currently under the purview of Accelerated Publishing) to interact with AWS resources.
+
+- `svc-gh-vagov-ap-user`
+

READMES/devops/tugboat.md

@@ -33,3 +33,23 @@ Can only update CPU and memory at a project level, not repository level.
 1. `tugboat ls 5fd3b8ee7b465711575722d5 -j | grep memory` # Get current limit
 1. `tugboat update 5fd3b8ee7b465711575722d5 memory=16384` # Set limit to 16GB
 1. `tugboat ls 5fd3b8ee7b465711575722d5 -j | grep memory` # Verify new limit
+
+## Tugboat Crisis Intervention
+
+### Overload
+
+**Symptoms**: Tugboat is slow, requests to Tugboat dashboard return 502/504 status codes, previews disappear and reappear, etc.
+
+**Diagnosis**: Tugboat might be overloaded; too many previews might be running simultaneously.
+
+**Verification**: 
+
+1. Log into the Tugboat server (`ssm-session utility tugboat auto`).
+2. Check system load and free memory (e.g. `top`).
+3. If load is incredibly high, and available memory is very low, then the Tugboat server might be dealing with too many open previews.
+
+**Remediation**:
+
+1. Close unused previews in the CMS/Pull Requests project. Target older previews and those corresponding to closed/merged PRs; these should be closed automatically, but there may be issues somewhere in the system that impair communication and cause these to remain open.
+2. Suspend older previews. This normally happens automatically (for Pull Request-based previews that haven't been touched in some period of time), but a flurry of previews might have been created inadvertently.
+3. Consider upscaling the Tugboat server or migrating to an alternative architecture.