VACMS-12994: Install node and npm on DDEV and Tugboat (#13054)

* VACMS-12870: change DDEV and tugboat to nvm

* VACMS-12870: added npm check

* VACMS-12870: removed mouf installer from composer

* VACMS-12870: fix for composer

* VACMS-12870: reconfigured script to install nvm, nvm install after cd in build

* VACMS-12870: fresh commit of all work

* VACMS-12870: fix script perms, fresh composer.lock

* VACMS-12870: fix for va:web:install in bash shell

* VACMS-12870: fix for typo

* VACMS-12994: updated composer.lock

* VACMS-12994: updated composer.lockl

* VACMS-12994: updated composer.lock

* VACMS-12994: updated composer.lock

* VACMS-12994: updated composer.lock

---------

Co-authored-by: Nathan Douglas <[email protected]>

Author: edmund-dunn

.ddev/config.yaml

@@ -19,6 +19,7 @@ hooks:
   - exec: drush deploy
   post-start:
   - exec: ./scripts/install_task_runner.sh
+  - exec: ./scripts/install-nvm.sh
   - composer: install
   - composer: va:theme:compile
   - composer: va:web:install

.nvmrc

@@ -1 +1 @@
-14.15.0
+16.19.1

.tugboat/config.yml

@@ -24,17 +24,17 @@ services:
     # A set of commands to run while building this service
     commands:
       # Commands that set up the basic preview infrastructure
-      
+
       # Changes made in this section will _not_ automatically take effect when
-      # base previews are refreshed through the scheduled process! A manual 
+      # base previews are refreshed through the scheduled process! A manual
       # rebuild of the base preview is necessary.
       init:
         - apt-get update
 
         # TODO: Add "Why" comment for Python, was this for the FE dependencies `yarn install`, if so which dependencies
         # so we can remove if they are removed in the future.
         - apt-get install python
-        
+
         # General useful development tools
         - apt-get install jq nano
 
@@ -128,6 +128,9 @@ services:
         - pecl install memcache-8.0
         - docker-php-ext-enable memcache
 
+        # Install node and npm.
+        - ./scripts/install-nvm.sh
+
         # Ensure that we're using version 2 of composer.
         - composer self-update --2
 
@@ -148,9 +151,10 @@ services:
         # Install/update packages managed by composer, including drush.
         # Composer options are in composer.json, 'config' key.
         - composer install
-        - ./bin/npm install
-        - composer va:theme:compile
-        - composer va:web:install
+        - bash -lc 'nvm install'
+        - bash -lc 'npm install'
+        - bash -lc 'composer va:theme:compile'
+        - bash -lc 'composer va:web:install'
 
         - curl --remote-name https://dsva-vagov-prod-cms-backup-sanitized.s3-us-gov-west-1.amazonaws.com/files/cms-prod-files-latest.tgz
         - tar --extract --gunzip --file cms-prod-files-latest.tgz --directory "${DOCROOT}/sites/default/files/"
@@ -179,9 +183,10 @@ services:
         - j2 "${TUGBOAT_ROOT}/.web/403-error-document.j2.html" -o "${TUGBOAT_ROOT}/.web/403-error-document.html"
         - j2 "${TUGBOAT_ROOT}/.storybook/403-error-document.j2.html" -o "${TUGBOAT_ROOT}/.storybook/403-error-document.html"
         - composer install
-        - ./bin/npm install
-        - composer va:theme:compile
-        - composer va:web:install
+        - bash -lc 'nvm install'
+        - bash -lc 'npm install'
+        - bash -lc 'composer va:theme:compile'
+        - bash -lc 'composer va:web:install'
         # https://www.drush.org/latest/deploycommand/ (updatedb, cache:rebuild, config:import, deploy:hook)
         - drush deploy
 

composer.json

@@ -186,7 +186,6 @@
         "mglaman/phpstan-drupal": "^1.0",
         "michelf/php-markdown": "^2.0",
         "mikey179/vfsstream": "^1.6",
-        "mouf/nodejs-installer": "^1.0",
         "npm-asset/dropzone": "^5.5",
         "npm-asset/yarn": "1.19.1",
         "oomphinc/composer-installers-extender": "^2.0",
@@ -297,8 +296,8 @@
             "drupal/core-composer-scaffold": true,
             "zaporylie/composer-drupal-optimizations": true,
             "drupal/console-extend-plugin": true,
-            "mouf/nodejs-installer": true,
             "oomphinc/composer-installers-extender": true,
+            "mouf/nodejs-installer": true,
             "dealerdirect/phpcodesniffer-composer-installer": true,
             "php-http/discovery": true
         }
@@ -321,13 +320,6 @@
                 "web-root": "docroot/"
             }
         },
-        "mouf": {
-            "nodejs": {
-                "version": "^16.0.0",
-                "targetDir": "docroot/vendor/nodejs/nodejs",
-                "forceLocal": true
-            }
-        },
         "installer-types": [
             "bower-asset",
             "npm-asset"

composer.lock

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+
+# Install NVM.
+curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash
+
+# Make sure we can run it.
+export NVM_DIR="$HOME/.nvm"
+[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
+[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion
+
+nvm install 16.19.1

scripts/install-nvm.sh

@@ -13,7 +13,7 @@ echo "Node $(node -v)"
 echo "NPM $(npm -v)"
 echo "Yarn $(yarn -v)"
 
-./scripts/composer/check-yarn-version.sh
+./scripts/composer/check_yarn_version.sh
 
 pushd "./web"
 yarn run install-repos