Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] [Analytics] [Campaign Landing Pages] Custom GA events removal & web components upgrades #18507

Open
4 tasks
randimays opened this issue Jul 12, 2024 · 0 comments
Labels
Blocked Issues that are blocked on factors other than blocking issues. Campaign Landing Page Marketing campaign oriented, CMS-managed product owned by Public Websites team ghp-backlog points-1 Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@randimays
Copy link
Contributor

Blocked

Blocked by this DST defect: department-of-veterans-affairs/vets-design-system-documentation#2817

We cannot convert this to a va-link until that accessibility defect is addressed.

Description

The va-link web component's analytics now include link destination, and va-link-action has been released to the component library. We can now use baked-in analytics for Campaign Landing Pages download links.

User story

AS A PO/PM managing Sitewide products & features
I WANT to (where appropriate) adopt the va-link or va-link-action component, its baked-in analytics, and remove the custom GA events
SO THAT extraneous code is removed and only the events needed will be triggered.

Engineering notes

Content-build template: https://github.com/department-of-veterans-affairs/content-build/blob/7c123600579e02589bbfc0b17408492e6adc363c/src/site/layouts/campaign_landing_page.drupal.liquid#L299

Acceptance criteria

  • Element: "Download ___ PDF" links
    • upgrade to web component
    • enable web component analytics
  • a11y review
@randimays randimays added Blocked Issues that are blocked on factors other than blocking issues. Campaign Landing Page Marketing campaign oriented, CMS-managed product owned by Public Websites team Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area labels Jul 12, 2024
@FranECross FranECross changed the title [Analytics] [Campaign Landing Pages] Custom GA events removal & web components upgrades [BLOCKED] [Analytics] [Campaign Landing Pages] Custom GA events removal & web components upgrades Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that are blocked on factors other than blocking issues. Campaign Landing Page Marketing campaign oriented, CMS-managed product owned by Public Websites team ghp-backlog points-1 Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

2 participants