Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the "Your submission is in Progress" alert for retryable, and non-retryable https responses #94222

Closed
3 tasks
pacerwow opened this issue Oct 3, 2024 · 2 comments
Assignees
Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience

Comments

@pacerwow
Copy link
Contributor

pacerwow commented Oct 3, 2024

Issue Description

As a Veteran I want status information on the confirmation page that is consistent with the status of my application so that I feel that understanding submission status is trivial. I expect the confirmation message to truthfully communicate the status of my application.

This story covers these possible error scenarios at the time of submission.
200 no claim id
401 unauthorized
402 bad request
404 no record found
500 ?

For reference the Figma design file for this feature is here.

Tasks

  • [ ]

Acceptance Criteria

  • The yellow warning alert on the Confirmation page is removed and is no longer possible to show to the Veteran
  • A green success alert is shown on the Confirmation for any success, retryable, and non-retryable http responses
  • All scenarios are tested and known to be working

Additional Information

Open questions

Do we still need a generic red error alert on the Confirmation page? I know that we expect the vast majority, if not all, form errors to be caught on Review & Submit, but are there any remaining edge cases where we may need a red generic error? See #94479

How might we break this up to be smaller? Should we move the 200 no claim id scenario to #94421

@pacerwow pacerwow added DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission. labels Oct 3, 2024
@pacerwow pacerwow changed the title Implement design into Confirmation page show the "In Progress" alert for success, and retryable, and non-retryable https responses Oct 7, 2024
@pacerwow pacerwow added zero-silent-failures Work related to eliminating silent failures and removed zero-silent-failures Work related to eliminating silent failures labels Oct 7, 2024
@pacerwow pacerwow changed the title show the "In Progress" alert for success, and retryable, and non-retryable https responses show the "Your submission is in Progress" alert for success, and retryable, and non-retryable https responses Oct 10, 2024
@pacerwow pacerwow removed zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission. labels Oct 10, 2024
@pacerwow pacerwow changed the title show the "Your submission is in Progress" alert for success, and retryable, and non-retryable https responses show the "Your submission is in Progress" alert for retryable, and non-retryable https responses Oct 17, 2024
@christinec-fftc
Copy link
Contributor

christinec-fftc commented Oct 17, 2024

From what i understand, the no claim id scenario would come after the 30 seconds wait, so I think we should keep that separate from the success scenario with claim id.

We could separate this into two stories

  1. 200 with no claim id
  2. non 200 scenarios testing

@pacerwow
Copy link
Contributor Author

Closed as a dupe, replaced by #95241

@pacerwow pacerwow closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience
Projects
None yet
Development

No branches or pull requests

3 participants