Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Confirmation Page: Non 200 submission status testing #95245

Closed
3 tasks done
christinec-fftc opened this issue Oct 17, 2024 · 2 comments · Fixed by department-of-veterans-affairs/vets-website#33083
Closed
3 tasks done
Assignees
Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex engineering Engineering topics frontend zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission.

Comments

@christinec-fftc
Copy link
Contributor

christinec-fftc commented Oct 17, 2024

Issue Description

Handle non 200 (error) scenarios from submission_status. For each of these, we should still display the green success alert since failure notification will come via email. Likely no code changes here, just testing.

Dependent on

Tasks

  • Mock up a non-200 response from vets-api
  • Test scenarios for different http codes, as needed

Based on docs here
401 unauthorized
403 forbidden
404 no record found
500 or any other non 200?

mocks: https://www.figma.com/design/qyTtKDOTHZPGU59PAfqVhq/(526ez)-New-Confirmation-Page-and-Email-Touchpoints?node-id=8405-81028

Acceptance Criteria

  • Verify success alert is displayed and yellow alert does not display.
@christinec-fftc christinec-fftc added DBEX-TREX Disability Benefits Experience - Team T-Rex engineering Engineering topics frontend labels Oct 17, 2024
@pacerwow pacerwow added zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission. labels Oct 17, 2024
@aurora-a-k-a-lightning
Copy link
Contributor

during testing for
#95241
department-of-veterans-affairs/vets-website#33012

i tested throwing a 500 error:

  • frontend polled 3 times
  • got 500 internal server error each time
  • on the third poll, frontend pushed forward to new confirmation screen with green box, no claim id version (expected)!

@christinec-fftc
Copy link
Contributor Author

Found a similar response as ahay's notes above, testing with 401, 403, 404 and 500 response codes video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBEX-TREX Disability Benefits Experience - Team T-Rex engineering Engineering topics frontend zero-silent-failures Work related to eliminating silent failures ZSF:UserExperience User experience changes on confirmation page/emails to clarify the status of the submission.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants