Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging Review finding: Include guidance on privacy masking for sensitive prefilled content. #95785

Closed
shiragoodman opened this issue Oct 15, 2024 · 3 comments
Assignees
Labels
a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints accessibility auth-exp-design-patterns Patterns used in the authenticated experience collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension exp-std-task-completion guidance modality-screen-reader platform-design-system-team VA.gov platform design system team's tickets Staging

Comments

@shiragoodman
Copy link
Contributor

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Design System Staging Information

Component: Help users to... Know when their information is prefilled
Staging Review ticket: AEDP, Design Patterns, Help users to... Know when their information is prefilled

Findings details

VA.gov Experience Standard - issue: User doesn't have enough information to complete a task.
VA.gov Experience Standard - category: Comprehension
This is an issue with the: guidance
High-priority: No
Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

In the Personal information page anatomy section, the Veteran's Social Security number is displayed with the first five digits masked. I don't think we have anywhere in the design system that currently tells VFS teams how to mask digits like this in an accessible way, and this feels to me like an appropriate place to do it.

Recommended action

Up to you to decide where this should be inserted --- I'm thinking possibly in the still pending Code Usage section or in a standalone Accessibility Considerations section (example of an Accessibility Considerations section), but you obviously know where it should go.

When masking characters, what we definitely don't want is screen reader software reading "Social Security Number: star star star dash star star dash 1234." The visible text with masked values should be wrapped in a <span aria-hidden="true"> (this tells screen readers to ignore it), and then followed immediately by something like <span class="sr-only">Number ending in 1234</span> (this tells screen readers what to announce instead).

I would also encourage you to work with CAIA to establish guidance on what kinds of data should/shouldn't be masked for privacy, and include that here as well. But at a minimum I think the code guidance would be a huge benefit.

References


Next Steps for DST

  • Close the ticket when the issue has been resolved or validated by your Product Owner
  • If your team has additional questions or needs Governance help validating the issue, please comment on the ticket
  • If this ticket has a high-priority label, please address as soon as possible so VFS teams are not impacted
  • If this ticket has a consider label, please consider for future implementation
@shiragoodman shiragoodman added a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints accessibility auth-exp-design-patterns Patterns used in the authenticated experience collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension DS-Staging-Review Tickets related to Design System Staging Reviews exp-std-task-completion guidance modality-screen-reader platform-design-system-team VA.gov platform design system team's tickets Staging labels Oct 15, 2024
@shiragoodman shiragoodman transferred this issue from department-of-veterans-affairs/vets-design-system-documentation Oct 24, 2024
@shiragoodman shiragoodman changed the title DST Staging Review: Include guidance on privacy masking for sensitive prefilled content. Staging Review finding: Include guidance on privacy masking for sensitive prefilled content. Oct 24, 2024
@msbtterswrth
Copy link
Contributor

We are tracking this update in this task in our team repo.

@humancompanion-usds humancompanion-usds added PO-Sync-approved Collab Cycle PO Syn was approved by OCTO leads and removed PO-Sync-approved Collab Cycle PO Syn was approved by OCTO leads labels Oct 30, 2024
@msbtterswrth
Copy link
Contributor

I chatted with Matt Dingee about this a bit, and we think that putting this guidance in the prefill pattern page doesn't make sense. We'll instead make a recommendation and open a PR to update the existing Social Security number pattern.

@shiragoodman
Copy link
Contributor Author

@briandeconinck FYI

@shiragoodman shiragoodman removed the DS-Staging-Review Tickets related to Design System Staging Reviews label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-3 Medium-severity accessibility issue that should be fixed within 1 - 3 sprints accessibility auth-exp-design-patterns Patterns used in the authenticated experience collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension exp-std-task-completion guidance modality-screen-reader platform-design-system-team VA.gov platform design system team's tickets Staging
Projects
None yet
Development

No branches or pull requests

3 participants