Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VETS-API] Backend CI - Expanded BE Team approach #97156

Open
3 tasks
ryan-mcneil opened this issue Nov 14, 2024 · 0 comments
Open
3 tasks

[VETS-API] Backend CI - Expanded BE Team approach #97156

ryan-mcneil opened this issue Nov 14, 2024 · 0 comments

Comments

@ryan-mcneil
Copy link
Contributor

The work here lead to the realization that we need to simplify our approach. Chatting with a couple BE folks, and getting approval from Clint, we've decided we're going to modify our approach by including members from the "exempt team" (Mobile, LH, Identity) in the backend-review-group and they will be tasked with approving their greater teams' respective PRs. This will require reworking (and simplifying) the work done in this PR, and testing.

Tasks

  • Rework the work done in the ticket/PR linked above to remove checks for "exempt" teams, but add in step to request approval from specific individuals on those exempt teams (who will also be added to the backend team)
  • Test locally and in "production"

Acceptance Criteria

  • Workflow is merged to master and everyone is happy.
@ryan-mcneil ryan-mcneil added needs-refinement Identifies tickets that need to be refined platform-reliability-team labels Nov 14, 2024
@ryan-mcneil ryan-mcneil self-assigned this Nov 14, 2024
@ericboehs ericboehs removed the needs-refinement Identifies tickets that need to be refined label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants