Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical red error line disappears on design.va.gov at some breakpoints #3787

Open
2 tasks
danbrady opened this issue Feb 10, 2025 · 0 comments
Open
2 tasks

Comments

@danbrady
Copy link
Contributor

Description

From the slack thread🔒:

"This is an issue with how the component is embedded in the docs site, not the component itself. Both SB and the docs site embed the same component code but the doc site uses an iframe. That component when in error state shifts to the left when the browser (or iframe) is at a desktop breakpoint or bigger. In the docs site, the bar is shifted left out of the bounds of the preview iframe/container. Shrinking your browser smaller will bring it back. (1st video below.) This shift happens in storybook too, but the border doesn't shift out of the preview container."

Thread includes videos of issue.

Tasks

  • [Engineers may provide tasks required to fix]

Acceptance Criteria

  • When a viewing a component with an error state on design.va.gov (mostly form elements), ensure the red, vertical line indicated an error is visible at all breakpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant