Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Semantic Tokens for gutters #3803

Open
3 tasks
caw310 opened this issue Feb 14, 2025 · 3 comments
Open
3 tasks

Create Semantic Tokens for gutters #3803

caw310 opened this issue Feb 14, 2025 · 3 comments
Assignees
Labels
DST-Design Use to designate DS designer work platform-design-system-team

Comments

@caw310
Copy link
Contributor

caw310 commented Feb 14, 2025

Description

As part of the normalizing the gutters to make UI and UX more consistent, it was decided to create semantic tokens for gutters.

Tasks

  • Create semantic tokens for gutters
  • Share the information with developers to add

Acceptance Criteria

  • Semantic tokens for gutters created
@caw310 caw310 added DST-Design Use to designate DS designer work platform-design-system-team labels Feb 14, 2025
@micahchiang
Copy link
Contributor

Perhaps useful information - https://designsystem.digital.gov/utilities/layout-grid/#gutters-2

We probably want to set the values of our gutter tokens to align with whatever these uswds values are. I imagine we could end up using the layout grid gutters above in things like sitewide layouts, and if teams need to specify their own gutters in custom stylesheets, we'd want those values to remain consistent.

@danbrady
Copy link
Contributor

I believe that "gutters" and "margins" are being used interchangeably, which may lead to different expectations and effort required.

The recent research and design work focused on the margins in the layout grid, specifically the left and right side padding at various breakpoints.

I consider "gutters" as the space between columns. This was not requested and was not part of the initial research and design. However, since we have approval to align the margins with the USWDS, it seems reasonable to align the gutters as well. We should confirm this. Please note that there are currently no design assets for gutters, and we will likely need additional tokens for them.

Since margins and gutters work in conjunction with the grid's max-width, we might want to consider adjusting that as well. Currently, we are at 1000px, but we would like to be at 1024px. However, adjusting this without updating the global header and footer could lead to misalignment, so this can get tangled up very quickly.

All this to say, let's discuss. 😄

@micahchiang
Copy link
Contributor

Ah okay, that makes things a little clearer for me 👍

So speaking to just the margins (which in CSS terms is actually padding here) we get some things for free from the uswds layout grid. 2 units at narrow widths and 4 units at desktop and wider.

We also get the 1024px width for free if we use the grid container they provide. And, if need be, we can customize some theme settings for layout grid margin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-Design Use to designate DS designer work platform-design-system-team
Projects
None yet
Development

No branches or pull requests

3 participants