Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST Staging Review: Guidance unclear on when to use indeterminate vs. checkbox group #3805

Open
shiragoodman opened this issue Feb 14, 2025 · 1 comment

Comments

@shiragoodman
Copy link
Collaborator

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Design System Staging Information

Component: checkbox
Staging Review ticket: Design System Staging Review: Checkbox indeterminate state

Findings details

VA.gov Experience Standard - issue: User has enough information to complete a task.
VA.gov Experience Standard - category: Comprehension
This is an issue with the: guidance
High-priority: No
Collab Cycle Reviewer: @erinrwhite (IA), @briandeconinck (Accessibility), @allison0034 (Design)

Description

It's not clear to me when the indeterminate state might be used instead of a regular ol' checkbox group component. The guidance isn't super clear on this. Is this when a list of options is larger than a certain number? Is this when we want people to be able to select all/deselect all easily? I also wonder if the example text itself might be updated with a real potential use-case on VA.gov rather than example data. There's no accompanying component in USWDS so more detail would be helpful here.

The guidance also directs you to the mutually exclusive answer pattern, seems to advise against using the indeterminate state for that pattern. Linking to that pattern with so little supporting guidance is likely to cause confusion around when it is an appropriate choice.

Recommended action

Add more documentation in the guidance...

  • When this variant might be used instead of checkbox group
  • Limits/minimums on number of suggested items?
  • "Real" or at least more VA-specific example content (I realize all the other examples are similar to this one but this is an example that really would benefit from more detail/context)

References

  • Accessibility Defect Severity: N/A
  • WCAG Success Criteria: N/A
  • Modality: N/A
  • Design System Pattern or Template: N/A
  • Design System Foundation: N/A
  • Content Style Guide: N/A
  • Context: N/A

Next Steps for DST

  • Close the ticket when the issue has been resolved or validated by your Product Owner
  • If your team has additional questions or needs Governance help validating the issue, please comment on the ticket
  • If this ticket has a high-priority label, please address as soon as possible so VFS teams are not impacted
  • If this ticket has a consider label, please consider for future implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants