Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST Staging Review: Wrong aria-checked value when no checkboxes checked #3807

Open
shiragoodman opened this issue Feb 14, 2025 · 0 comments
Open

Comments

@shiragoodman
Copy link
Collaborator

shiragoodman commented Feb 14, 2025

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Design System Staging Information

Component: checkbox
Staging Review ticket: Design System Staging Review: Checkbox indeterminate state

Findings details

The details of this ticket are for consideration only. No Staging Review issue was found.
High-priority: No
Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

When no sub-checkboxes are checked, the "Select all" checkbox is visually unchecked, but it still has the aria-checked="mixed" value.

Oddly enough, it seems to be correctly announced by screen readers that I tested with, so there isn't any immediate impact that I'm aware of. But there may be some assistive technology where the state doesn't get correctly communicated.

Recommended action

Remove the aria-checked attribute when all sub-checkboxes are unchecked.

References


Next Steps for DST

  • Close the ticket when the issue has been resolved or validated by your Product Owner
  • If your team has additional questions or needs Governance help validating the issue, please comment on the ticket
  • If this ticket has a high-priority label, please address as soon as possible so VFS teams are not impacted
  • If this ticket has a consider label, please consider for future implementation#N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants