Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate "autocomplete" attributes in va-search-input #3811

Open
2 of 6 tasks
coforma-jamie opened this issue Feb 18, 2025 · 0 comments
Open
2 of 6 tasks

Duplicate "autocomplete" attributes in va-search-input #3811

coforma-jamie opened this issue Feb 18, 2025 · 0 comments
Labels
bug Something isn't working platform-design-system-team

Comments

@coforma-jamie
Copy link
Contributor

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

<va-search-input> tells the browser to “do something” to autocomplete in two ways - HTML (autocomplete=”off”) and ARIA (aria-autocomplete=”none”).

HTML autocomplete=”off” is picked up by assistive tech (AT) and implements autocomplete behavior. ARIA aria-autocomplete=”none” is picked up by AT, but doesn’t actually implement any behavior.

Since autocomplete="off does what's needed already, you should be able to safely remove aria-autocomplete="none".

Image

What I expected to happen

Only one autocomplete attribute is used to prescribe autocomplete behavior in <va-search-input>

Reproducing

  • CSS Library version:
  • Device: (Macbook
  • Browser: Chrome

Steps to reproduce:

  1. Go to Resources and Support
  2. Inspect <va-search-input> component used under "Search resources and support articles or all of VA>gov"

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

This is a minor issue and isn't affecting AT users. Fixing this will simply tidy up the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform-design-system-team
Projects
None yet
Development

No branches or pull requests

1 participant