Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern to Request Multiple Signatures - Design #3813

Open
31 tasks
caw310 opened this issue Feb 18, 2025 · 0 comments
Open
31 tasks

Pattern to Request Multiple Signatures - Design #3813

caw310 opened this issue Feb 18, 2025 · 0 comments
Assignees
Labels
DST-Design Use to designate DS designer work pattern-new Proposed new pattern platform-design-system-team

Comments

@caw310
Copy link
Contributor

caw310 commented Feb 18, 2025

Description

Create the pattern to request multiple signatures inFigma.

Details

Confluence page with instructions: https://vfs.atlassian.net/l/cp/JR0BtAa1

Tasks

  • Create designs for pattern in Figma
  • Review designs with PO and/or other DST designers
  • Review designs with an accessibility specialist
  • Review designs with DST members
  • Address any comments from reviews, if necessary
  • Comment on this ticket with any accessibility considerations engineers may need to know
  • Comment on this ticket with content specifications (e.g. labels and error messages)
  • Comment on this ticket with a link to the designs and post in DST Slack channel

Acceptance Criteria

Styles & Variables/Token

  • All components should be connected to VADS Component Library styles & Variables
  • All components should be connected to the proper style or variable/token
    • Colors: connected to the correct color token (not primitive!) - can be found in local variables library
    • Typography: connected to the correct text style - under local styles
    • Spacing: connected to the correct spacing token or primitive
    • Icons: connected to correct icon - can be found on foundation page

Auto layout

  • Components should be as reactive as possible. Most, if not all, components should be able to be resize for either mobile, tablet, or desktop sizes
  • The correct spacing should be applied to auto layout

Properties

Note

Not all components need every property. It will differ component to component

  • Variants: Should be used when the component has several states i.e primary, secondary, error
  • Boolean: Should be used if the component has a part that does not always need to be shown i.e icons, nested components and mobile view
  • Text: Should be used when the test on a component needs to be changed. There are some exceptions to this if the component has several variants that need to have different/specific text. When you change the text on the parent component it will change all of the variants
  • Instance Swap
    • Should be used if there is a part of the component that needs to be switched out but nothing else needs to change i.e. icons Color contrast (Pro Tip: The plugin “Contrast” can help with this.)
  • Test as a DS library user
    • Connect your Figma design file to the DS library found in the Assets panel, Team Library (open book icon)
    • After connecting to the library, use the Assets panel to view all components
    • Does the component naming make sense and follow storybook?
    • Try to break the component! Test on asset NOT parent component
    • Expand/shrink the asset and put into containers
    • change body text and/or header from a sentence to paragraph
    • make sure text wraps correctly
    • the component should expand or shrink with text
    • Test all combinations of properties
@caw310 caw310 added DST-Design Use to designate DS designer work pattern-new Proposed new pattern platform-design-system-team labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DST-Design Use to designate DS designer work pattern-new Proposed new pattern platform-design-system-team
Projects
None yet
Development

No branches or pull requests

3 participants