Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-telephone message aria describedby #3885

Open
2 of 6 tasks
Mottie opened this issue Mar 6, 2025 · 0 comments
Open
2 of 6 tasks

va-telephone message aria describedby #3885

Mottie opened this issue Mar 6, 2025 · 0 comments
Labels
bug Something isn't working platform-design-system-team va-telephone DS telephone component

Comments

@Mottie
Copy link

Mottie commented Mar 6, 2025

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

This doesn't appear to be an actual bug, but in storybook, the message-aria-describedby property is set to false and this leads the component to interpret that value as a string and eventually renders a screen-reader only span in the shadow DOM with the text "false". It may be a rare occurrence in actual web component usage, so it may still need to be addressed.

inspecting the shadow DOM of va-telephone reveals a span with an screen reader only class that contains the word "false"

What I expected to happen

Don't include messageAriaDescribedBy value if set to false

Reproducing

  • CSS Library version: All
  • Device: (e.g. iPhone 8, Macbook): All
  • Browser: (e.g. Firefox, IE 11): All

Steps to reproduce:

  1. Go to va-telephone in storybook
  2. Inspect the DOM of the first va-telephone web component

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

@Mottie Mottie added bug Something isn't working platform-design-system-team va-telephone DS telephone component labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform-design-system-team va-telephone DS telephone component
Projects
None yet
Development

No branches or pull requests

1 participant