Merge pull request #292 from derbyjs/dev-updates

Switch CI to GitHub actions, update devDependencies

Author: ericyhwang

.eslintrc.js

@@ -1,15 +1,15 @@
 // The ESLint ecmaVersion argument is inconsistently used. Some rules will ignore it entirely, so if the rule has
 // been set, it will still error even if it's not applicable to that version number. Since Google sets these
 // rules, we have to turn them off ourselves.
-const DISABLED_ES6_OPTIONS = {
+var DISABLED_ES6_OPTIONS = {
   'no-var': 'off',
   'prefer-rest-params': 'off',
   'prefer-spread': 'off',
   // Not supported in ES3
   'comma-dangle': ['error', 'never']
 };
 
-const CUSTOM_RULES = {
+var CUSTOM_RULES = {
   'one-var': 'off',
   // We control our own objects and prototypes, so no need for this check
   'guard-for-in': 'off',
@@ -18,7 +18,7 @@ const CUSTOM_RULES = {
   'indent': ['error', 2, {'SwitchCase': 1}],
   // Less aggressive line length than Google, which is especially useful when we have a lot of callbacks in our code
   'max-len': ['error', {code: 120, tabWidth: 2, ignoreUrls: true}],
-  // Google overrides the default ESLint behaviour here, which is slightly better for catching erroneously unused variables
+  // Go back to default ESLint behaviour here, which is slightly better for catching erroneously unused variables
   'no-unused-vars': ['error', {vars: 'all', args: 'after-used'}],
   'require-jsdoc': 'off',
   'valid-jsdoc': 'off'
@@ -27,11 +27,11 @@ const CUSTOM_RULES = {
 module.exports = {
   extends: 'google',
   parserOptions: {
-    ecmaVersion: 3
+    ecmaVersion: 5
   },
   rules: Object.assign(
     {},
     DISABLED_ES6_OPTIONS,
     CUSTOM_RULES
-  ),
+  )
 };

.github/workflows/test.yml

@@ -0,0 +1,51 @@
+# https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs-or-python
+
+
+name: Test
+
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+    branches:
+    - master
+
+jobs:
+  test:
+    name: Node.js ${{ matrix.node }}
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node:
+        - 10
+        - 12
+        - 14
+        - 16
+    timeout-minutes: 5
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-node@v2
+      with:
+        node-version: ${{ matrix.node }}
+    - run: npm install
+    - run: npm run lint
+      if: ${{ matrix.node >= 12 }}  # eslint@8 only supports Node >= 12
+    - run: npm run test-cover
+    # https://github.com/marketplace/actions/coveralls-github-action#complete-parallel-job-example
+    - name: Coveralls
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        flag-name: node-${{ matrix.node }}
+        parallel: true
+
+  finish:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Submit coverage
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          parallel-finished: true

.mocharc.yml

@@ -0,0 +1,4 @@
+reporter: spec
+timeout: 1200
+check-leaks: true
+recursive: true

.travis.yml

@@ -10,8 +10,9 @@
   "main": "./lib/index.js",
   "scripts": {
     "lint": "eslint --ignore-path .gitignore .",
-    "test": "node_modules/.bin/mocha && npm run lint",
-    "test-cover": "node_modules/nyc/bin/nyc.js --temp-dir=coverage -r text -r lcov node_modules/mocha/bin/_mocha && npm run lint"
+    "test": "node_modules/.bin/mocha",
+    "posttest": "npm run lint",
+    "test-cover": "node_modules/nyc/bin/nyc.js --temp-dir=coverage -r text -r lcov node_modules/mocha/bin/_mocha"
   },
   "dependencies": {
     "arraydiff": "^0.1.1",
@@ -22,10 +23,10 @@
   "devDependencies": {
     "chai": "^4.2.0",
     "coveralls": "^3.0.5",
-    "eslint": "^5.16.0",
-    "eslint-config-google": "^0.13.0",
-    "mocha": "^6.1.4",
-    "nyc": "^14.1.1"
+    "eslint": "^8.1.0",
+    "eslint-config-google": "^0.14.0",
+    "mocha": "^9.1.3",
+    "nyc": "^15.1.0"
   },
   "bugs": {
     "url": "https://github.com/derbyjs/racer/issues"