Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipping long lines #11

Open
ekrel opened this issue Jul 7, 2020 · 0 comments
Open

skipping long lines #11

ekrel opened this issue Jul 7, 2020 · 0 comments

Comments

@ekrel
Copy link

ekrel commented Jul 7, 2020

There appears to be a bug in handling skipping long lines. I think there should be an else condition before returning in ValueError. That is, long lines are checking in "if not at_eof" and then there should be an "else: return" if we are at_eof. Currently any long line will stop all further evaluation (e.g. if using poll()).

Separately, it would be great to be able to handle long lines in general. For example, this comes up in FIX logs when receiving security definitions. Perhaps there could be an option that emulates fh.readline()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant