Cleanup romantointeger.go (TheAlgorithms#328)

Co-authored-by: Yaolin_Li <[email protected]>
Co-authored-by: Andrii Siriak <[email protected]>

Author: 3 people

conversions/roman_to_integer/romantointeger.go

@@ -11,14 +11,12 @@ var romans = map[string]int{"I": 1, "V": 5, "X": 10, "L": 50, "C": 100, "D": 500
 
 func RomanToInteger(roman string) int {
 	total := 0
-	holder := 0
-	for holder < len(roman) {
-		if holder+1 < len(roman) && (romans[string(roman[holder])] < romans[string(roman[holder+1])]) {
-			total += romans[string(roman[holder+1])] - romans[string(roman[holder])]
-			holder += 2
+	romanLen := len(roman)
+	for holder := range roman {
+		if holder+1 < romanLen && romans[string(roman[holder])] < romans[string(roman[holder+1])] {
+			total -= romans[string(roman[holder])]
 		} else {
 			total += romans[string(roman[holder])]
-			holder++
 		}
 	}
 	return total